Send JSON error instead of entire 500 page error on autograde error #1679
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When there's an error in the partial feedback request a json
{ error: "Get partial feedback request failed: #{e}" }
with status internal_server_error gets rendered instead of a full 500 error page.Motivation and Context
Previously, if there's an autograding error, the error gets properly caught in the javascript of viewFeedback and functionally everything was fine, but the error response that gets sent is the HTML for the entire donkey 500 error page, which makes the response slower. This PR will return a simpler JSON.
Error response before:
Error response after:
How Has This Been Tested?
Types of changes
Checklist:
overcommit --install && overcommit --sign
to use pre-commit hook for linting