-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exposing Automerge::get_marks through to Swift #186
exposing Automerge::get_marks through to Swift #186
Conversation
Thanks @miguelangel-dev, I'll take a look in depth a little later today or tomorrow, WWDC is dominating my attention right now. In the meantime, Marks has some underlying changes that we should get in before dropping this in place - some API updates that align to the latest core library that I have in some commits in the WIP Blocks PR (#171). I'll pull those out of the existing PR and get those set up so we can merge them without waiting for the full detail work on the Blocks API |
@miguelangel-dev I don't think there'll be a serious conflict, but go ahead and rebase over the #171 merge, and things should be good. Biggest detail change here was the internal API switching from Value to ScalarValue inside marks, which I wanted to get in if we were expanding the marks API with these bits. |
2788b02
to
1834d62
Compare
Thanks for moving and merging. I have rebased it against #171 - it should be ready to review 🙏🏻 |
Co-authored-by: Joseph Heck <heckj@mac.com>
Thanks both for the code review, I have addressed all your suggestions. It is ready for a second round 🙏🏻 |
Sorry, added a latest minor change to revert an unnecessary public accessibility into the cursor c6798ff |
Bindings for being able to retrieve the marks of a given position without traversing the ops of the full document.
https://automerge.org/automerge/automerge/struct.Automerge.html#method.get_marks