Prevents coupling UTF-16 text value encodings to WASM targets #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelangel-dev
force-pushed
the
migue/wasm-text-value-encoding
branch
3 times, most recently
from
7ed8c3e to
eef77b5
Compare
miguelangel-dev
force-pushed
the
migue/wasm-text-value-encoding
branch
3 times, most recently
from
286ee6c to
a8f0cb7
Compare
miguelangel-dev
force-pushed
the
migue/wasm-text-value-encoding
branch
from
a8f0cb7 to
271ed5d
Compare
heckj
reviewed
Oct 18, 2024
miguelangel-dev
force-pushed
the
migue/wasm-text-value-encoding
branch
from
d2572ef to
bccb29e
Compare
ci: wasm job minor minor minor missing wastime
miguelangel-dev
force-pushed
the
migue/wasm-text-value-encoding
branch
2 times, most recently
from
d6ce253 to
6eb0de3
Compare
miguelangel-dev
force-pushed
the
migue/wasm-text-value-encoding
branch
2 times, most recently
from
ce582d3 to
3b2cb60
Compare
miguelangel-dev
force-pushed
the
migue/wasm-text-value-encoding
branch
2 times, most recently
from
509794e to
ce582d3
Compare
minor
miguelangel-dev
force-pushed
the
migue/wasm-text-value-encoding
branch
from
ce582d3 to
b11a12e
Compare
heckj
approved these changes
Oct 26, 2024
There was a problem hiding this comment.
Looks completely reasonable to me. Thanks for the notes on the different platform options - I expect this to continue to be in flux over the coming few years, and hopefully there'll be options to make installation of SDKs and toolchains for CI easier (and more consistent) down the road.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs
Description
Because of misalignments in encoding width between UTF-16 and Unicode Scalars; when we use
emoji, or any other Unicode character, splice-text, markers and cursors won't work.Using Automerge 0.5.11
Previous to apply automerge#977
Using Automerge 0.5.12