-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework Envs #89
Rework Envs #89
Conversation
benjamc
commented
May 25, 2023
•
edited
Loading
edited
- New CARL env
- Port classic control
- Port brax
- Port dmc
- Port box2d
- Port mario
- Port RNA
- Add unit tests for new CARL env
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #89 +/- ##
===============================================
- Coverage 22.48% 19.05% -3.43%
===============================================
Files 76 78 +2
Lines 4479 4030 -449
Branches 565 555 -10
===============================================
- Hits 1007 768 -239
+ Misses 3423 3224 -199
+ Partials 49 38 -11 |
carl/context/context_space.py
Outdated
""" | ||
return [ | ||
UniformFloatHyperparameter( | ||
"gravity", lower=0.1, upper=np.inf, default_value=9.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ask Eddie about np.inf as bounds in uniform
|
||
return spaces.Box(low=low, high=high, dtype=np.float32) | ||
|
||
def sample_contexts( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Remove sample contexts
I updated Mario and RNA but couldn't test either:
So I'd add:
|
* Extend gitignore * Add DMC Finger (current status) * current status * Current status * Current status * Current status * Format * Format + pre-commit * Remove test notebook * Add method to check if it is okay to set context feature Because we might have incomplete contexts * Add more tests * Format * Format * Merge main * gravity bounds * More tests * Correct gravity bounds Co-authored-by: Carolin Benjamins <benjamins@tnt.uni-hannover.de> Co-authored-by: sebidoe <45859263+sebidoe@users.noreply.github.com>
* Fix format, fix tests * Fix format * Increase coverage * Remove test code * Add more tests Co-authored-by: Carolin Benjamins <benjamins@tnt.uni-hannover.de>
* update install_requires * § * fix imports: gym → gymnasium * fix step function * fix step * gym->gymnasium * § * fix * fix * fix * fix * fix * fix render * . * fix all step returns * Delete build/lib/carl directory * Delete myenv directory * Update README.md Fix documentation link. * make pre-commit and format * rename every occurrence of trunched to truncated * @Arman717 * change trunched to truncated * Fix gymnasium version with box2d --------- Co-authored-by: C. Benjamins <75323339+benjamc@users.noreply.github.com>