Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in calcCoordsFromCurrentViewMask in Sensor.cpp #35

Open
kuehnma opened this issue Feb 13, 2015 · 0 comments
Open

Inconsistency in calcCoordsFromCurrentViewMask in Sensor.cpp #35

kuehnma opened this issue Feb 13, 2015 · 0 comments

Comments

@kuehnma
Copy link
Contributor

kuehnma commented Feb 13, 2015

The function calcCoordsFromCurrentView returns the number of model points multiplied with 2.
In comparison calcCoordsFromCurrentViewMask returns the number of model points NOT multiplied with 2.
This might lead to an inconsistency in using both functions as equivalent behavior is expected.

Probably the error is located in Sensor.cpp in calcCoordsFromCurrentView in line 94. The counter for valid points is incremented for every point twice. In comparison calcCoordsFromCurrentViewMask is incremented for every point only once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant