remove networkpolicy from commonlabel defaults #1
Conversation
If we apply commonLabels to the spec of a networkpolicy it will alter the policy so it no longer matchs what was applied.
| @@ -144,19 +144,4 @@ commonLabels: | |||
| create: false | |||
| group: policy | |||
| kind: PodDisruptionBudget | |||
|
|
|||
| - path: spec/podSelector/matchLabels | |||
There was a problem hiding this comment.
This should still be allowed, no? It's referencing resources in the namespace.
There was a problem hiding this comment.
It's still allowed just not the default behaviour.
|
Open issue: kubernetes-sigs#1009 This is a likely breaking change that will be hard to merge back upstream. |
There was a problem hiding this comment.
@switj If we're going to run a fork of kustomize for applying the clusters, can you update the instructions on how one can get the fork? For normal apps we'd want to keep using the regular kustomize.
Otherwise if this is the only way to go I'm good with the change.
|
What is the alternative to forking kustomize? What is the impact. I do worry about forking and maintaining such a thing. |
If we apply commonLabels to the spec of a networkpolicy it will alter
the policy so it no longer matchs what was applied.