Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix victoria metrics integration #32

Merged
merged 10 commits into from
Feb 21, 2025
Merged

Fix victoria metrics integration #32

merged 10 commits into from
Feb 21, 2025

Conversation

clostao
Copy link
Member

@clostao clostao commented Feb 20, 2025 •
edited
Loading

Victoria metrics integration had some errors:

  • Not passing environment variables to file retriever
  • Bad authentication config
  • Bad measurement write formation

@clostao clostao changed the title Fix dockercompose Fix victoria metrics integration Feb 20, 2025
marc-aurele-besner
marc-aurele-besner approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@marc-aurele-besner marc-aurele-besner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clostao clostao merged commit 853bac9 into main Feb 21, 2025
@clostao clostao deleted the fix-dockercompose branch February 21, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc-aurele-besner marc-aurele-besner marc-aurele-besner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clostao @marc-aurele-besner