Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata dag builder #117

Merged
merged 4 commits into from
Oct 7, 2024
Merged

Add metadata dag builder #117

merged 4 commits into from
Oct 7, 2024

Conversation

clostao
Copy link
Contributor

@clostao clostao commented Oct 4, 2024

Added metadata dag builder abstracting the node building through builders parameter

Copy link

github-actions bot commented Oct 4, 2024

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Code Organization
Consider using a more structured approach or pattern for defining and exporting builders to improve maintainability and readability.

Function Complexity
The function createBufferIPLDDag seems to be doing multiple things which could be broken down into smaller, more focused functions.

Documentation
Some functions are missing comprehensive documentation comments that explain parameters and return types, which are essential for maintainability.

Copy link

github-actions bot commented Oct 4, 2024

PR Code Suggestions ✨

No code suggestions found for the PR.

Copy link
Collaborator

@marc-aurele-besner marc-aurele-besner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add createMetadataIPLDDag to the Auto-Drive README?

Copy link
Collaborator

@marc-aurele-besner marc-aurele-besner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@clostao clostao merged commit 97d6aed into main Oct 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants