Export remaining public functions of sc-service
#18
Conversation
dastansam
changed the title
sc-service
yes, in progress |
|
I generally open PR upstream first, then depending on how quickly they review it backport into Subspace fork. This way we can ensure in most cases that we land the same code that upstream does and not have merge conflicts down the line. Especially with PRs that are this simple. |
upstream PR was merged yesterday, how do you usually backport it? do we have to release a new branch |
|
No, if upstream PR is exactly the same as this branch (I see no link to it) then we're okay to merge this alrady. Otherwise I cherry-pick commits from upstream the way they were merged there. |
ah sorry paritytech#4457, the only difference is the prdoс |
It is fine, it'll not cause merge conflicts. We're good to go here 👍 |
I will go ahead and open PRs to update commit hashes of polkadot-sdk deps |
|
You'll have to update hash of the polkadot-sdk in our fork of Frontier as well |
while working on this issue autonomys/subspace#2765, I found out that functions used in
spawn_tasks()were converted to public but was not added to exported types/functions ofsc-service