Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons build script #265

Closed
wants to merge 3 commits into from
Closed

Add icons build script #265

wants to merge 3 commits into from

Conversation

dastansam
Copy link
Contributor

@dastansam dastansam commented Aug 5, 2024

this PR adds a build script for bundling icons with relm4-icons crate. This is a companion PR of Relm4/icons#19 and will enable us to upgrade that crate

@nazar-pc
Copy link
Member

nazar-pc commented Aug 5, 2024

Would you mind leaving some comment in PR description? I'm not sure what is the purpose of this.

@nazar-pc
Copy link
Member

nazar-pc commented Aug 7, 2024

Given how many conflicts there were in a single commit, wouldn't it be better to do rebase instead?

@dastansam dastansam force-pushed the relm-icons-build-fix branch 2 times, most recently from e9e7729 to d5e218a Compare August 7, 2024 06:43
@dastansam dastansam marked this pull request as ready for review August 7, 2024 06:43
@dastansam dastansam requested a review from nazar-pc August 7, 2024 06:44
@dastansam dastansam force-pushed the relm-icons-build-fix branch from d5e218a to 8255bde Compare August 7, 2024 06:47
@nazar-pc
Copy link
Member

nazar-pc commented Aug 7, 2024

Will set to draft until upstream at least receives a review. Do not want to merge something that points to a custom temporary fork.

@nazar-pc nazar-pc marked this pull request as draft August 7, 2024 07:07
@nazar-pc
Copy link
Member

nazar-pc commented Aug 7, 2024

Character escaping on Windows is not working properly

@dastansam dastansam force-pushed the relm-icons-build-fix branch from 8255bde to c2462be Compare August 8, 2024 21:52
@dastansam dastansam force-pushed the relm-icons-build-fix branch 2 times, most recently from 7ef4d74 to 93bc2c4 Compare August 28, 2024 13:53
@nazar-pc
Copy link
Member

@dastansam when do you plan to finish work here?

@dastansam
Copy link
Contributor Author

@dastansam when do you plan to finish work here?

this week, hopefully

@dastansam dastansam force-pushed the relm-icons-build-fix branch from 93bc2c4 to 32576c0 Compare October 3, 2024 06:41
@dastansam dastansam force-pushed the relm-icons-build-fix branch from 32576c0 to 059bb06 Compare October 3, 2024 14:20
@dastansam dastansam force-pushed the relm-icons-build-fix branch from e0e059e to 132faa5 Compare October 15, 2024 08:37
@nazar-pc
Copy link
Member

Can you rebase on main and squash everything so we can see if CI works?

@dastansam
Copy link
Contributor Author

Can you rebase on main and squash everything so we can see if CI works?

sure, can do the rebase, but my relm4-icons PR needs to be merged and released before that, no? or it's ok to point to my own fork?

@nazar-pc
Copy link
Member

nazar-pc commented Oct 15, 2024

Sure, let's do that, just to see how it works. It'll also be easier for me to test on my end. We'll update it to upstream release once it is out before merging this.

@nazar-pc
Copy link
Member

Ping?

@nazar-pc
Copy link
Member

@dastansam we can switch to upstream git revision now since Relm4/icons#19 was merged with TODO to switch to upstream release once it is available.

@dastansam
Copy link
Contributor Author

@dastansam we can switch to upstream git revision now since Relm4/icons#19 was merged with TODO to switch to upstream release once it is available.

sure, I had hard time pointing to the new build crate because it's not resolved by importing crate from git. Should the relm4-icons be converted to virtual workspace for that?

@nazar-pc
Copy link
Member

Do you have log with errors you were getting? The repo does have a workspace, so should not be an issue to pull any packages from it.

@dastanbeksamatov
Copy link

dastanbeksamatov commented Oct 25, 2024

Do you have log with errors you were getting? The repo does have a workspace, so should not be an issue to pull any packages from it.

yeah, simply trying to import build crate from git link is failing with "unresolved crate" error

@nazar-pc
Copy link
Member

I have a successor branch that is up to date and built on top of Relm4/icons#24, closing this.

Thanks for the heavy lifting here!

@nazar-pc nazar-pc closed this Oct 26, 2024
@nazar-pc nazar-pc deleted the relm-icons-build-fix branch October 26, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants