-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icons build script #265
Conversation
Would you mind leaving some comment in PR description? I'm not sure what is the purpose of this. |
Given how many conflicts there were in a single commit, wouldn't it be better to do rebase instead? |
e9e7729
to
d5e218a
Compare
d5e218a
to
8255bde
Compare
Will set to draft until upstream at least receives a review. Do not want to merge something that points to a custom temporary fork. |
Character escaping on Windows is not working properly |
8255bde
to
c2462be
Compare
7ef4d74
to
93bc2c4
Compare
@dastansam when do you plan to finish work here? |
this week, hopefully |
93bc2c4
to
32576c0
Compare
32576c0
to
059bb06
Compare
e0e059e
to
132faa5
Compare
Can you rebase on |
sure, can do the rebase, but my |
Sure, let's do that, just to see how it works. It'll also be easier for me to test on my end. We'll update it to upstream release once it is out before merging this. |
Ping? |
@dastansam we can switch to upstream git revision now since Relm4/icons#19 was merged with TODO to switch to upstream release once it is available. |
sure, I had hard time pointing to the new build crate because it's not resolved by importing crate from |
Do you have log with errors you were getting? The repo does have a workspace, so should not be an issue to pull any packages from it. |
yeah, simply trying to import build crate from git link is failing with "unresolved crate" error |
I have a successor branch that is up to date and built on top of Relm4/icons#24, closing this. Thanks for the heavy lifting here! |
this PR adds a build script for bundling icons with
relm4-icons
crate. This is a companion PR of Relm4/icons#19 and will enable us to upgrade that crate