-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update French translations #354
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just one question
res/translations/fr/messages.ftl
Outdated
running_node_title = {$chain_name} Nœud de la blockchain | ||
running_node_title_tooltip = Cliquez pour ouvrir dans le gestionnaire de fichiers | ||
# TODO: Translate | ||
running_node_connections_tooltip = {$connected_peers}/{$expected_peers} peers connected, click for details about required P2P ports | ||
running_node_connections_tooltip = {$connected_peers}/{$expected_peers} Pairs connectées, cliquez pour plus de détails sur les ports P2P requis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are words Nœud
and Pairs
capitalized, is that really how it is supposed to be? They are not capitalized in English and many other languages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, not at all, but in France (often) when a new window appears (new subject) it is capitalized
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, but the sentence starts with numbers in this case or with chain name on running_node_title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are correct, and I didn’t pay attention to the fact that the code starts with a number or a proper noun. Thank you for pointing that out! I’ll make the necessary adjustment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
No description provided.