Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update French translations #354

Merged
merged 2 commits into from
Dec 7, 2024
Merged

Update French translations #354

merged 2 commits into from
Dec 7, 2024

Conversation

Vlady19
Copy link
Contributor

@Vlady19 Vlady19 commented Dec 7, 2024

No description provided.

Copy link
Member

@nazar-pc nazar-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just one question

Comment on lines 97 to 99
running_node_title = {$chain_name} Nœud de la blockchain
running_node_title_tooltip = Cliquez pour ouvrir dans le gestionnaire de fichiers
# TODO: Translate
running_node_connections_tooltip = {$connected_peers}/{$expected_peers} peers connected, click for details about required P2P ports
running_node_connections_tooltip = {$connected_peers}/{$expected_peers} Pairs connectées, cliquez pour plus de détails sur les ports P2P requis
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are words Nœud and Pairs capitalized, is that really how it is supposed to be? They are not capitalized in English and many other languages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, not at all, but in France (often) when a new window appears (new subject) it is capitalized

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, but the sentence starts with numbers in this case or with chain name on running_node_title

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct, and I didn’t pay attention to the fact that the code starts with a number or a proper noun. Thank you for pointing that out! I’ll make the necessary adjustment

Copy link
Member

@nazar-pc nazar-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nazar-pc nazar-pc enabled auto-merge (squash) December 7, 2024 15:54
@Vlady19 Vlady19 disabled auto-merge December 7, 2024 15:58
@Vlady19 Vlady19 closed this Dec 7, 2024
@Vlady19 Vlady19 reopened this Dec 7, 2024
@nazar-pc nazar-pc enabled auto-merge (squash) December 7, 2024 16:04
@nazar-pc nazar-pc disabled auto-merge December 7, 2024 16:04
@nazar-pc nazar-pc enabled auto-merge (squash) December 7, 2024 16:04
@nazar-pc nazar-pc changed the title Update messages.ftl Update French translations Dec 7, 2024
@nazar-pc nazar-pc merged commit 2b26536 into autonomys:main Dec 7, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants