Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Add proper internationalization #218

Closed
isSerge opened this issue May 20, 2022 · 2 comments
Closed

Add proper internationalization #218

isSerge opened this issue May 20, 2022 · 2 comments
Assignees
@isSerge
Labels
backburner not a priority improvement it is already working, but can be better

Comments

@isSerge
Copy link
Contributor

isSerge commented May 20, 2022 •
edited
Loading

Currently, some texts are stored in the src/loc/en.json, however, there are a lot of labels that are hardcoded in the code, for example in src/components/disclaimer.vue:

q-dialog(@hide="onDialogHide" persistent ref="dialog")
  q-card
    q-card-section
      .row.items-center
        .text-h6 TESTNET DISCLAIMER
        q-space
        q-icon(color="grey" name="info" size="40px")
    q-card-section.q-pt-none
      | Tokens/credits generated on the Subspace Network testnet ("testSSCs") do not equate to Subspace Network mainnet tokens, have no monetary value, and cannot be exchanged for cash, cash equivalent, or other tokens or cryptocurrencies.
    q-card-actions(align='right')
      q-btn(flat='', label='I understand', color='primary', v-close-popup='')
@isSerge
Copy link
Contributor Author

isSerge commented May 20, 2022

Should utilize recommended internalization approach: https://quasar.dev/options/app-internationalization#introduction

@isSerge isSerge self-assigned this May 20, 2022
@isSerge isSerge changed the title Add proper localisation Add proper internationalization May 20, 2022
@isSerge isSerge added the improvement it is already working, but can be better label May 20, 2022
@ozgunozerk ozgunozerk added the backburner not a priority label May 20, 2022
@ozgunozerk ozgunozerk moved this from Todo to Backlog in Product Engineering May 20, 2022
@isSerge
Copy link
Contributor Author

isSerge commented Jul 11, 2022

Resolved by #280

@isSerge isSerge closed this as completed Jul 11, 2022
Repository owner moved this from Backlog to Done in Product Engineering Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isSerge isSerge

Labels
backburner not a priority improvement it is already working, but can be better
Projects
Product Engineering
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@isSerge @ozgunozerk