Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Add internalization #280

Merged
merged 5 commits into from
Jul 11, 2022
Merged

Add internalization #280

merged 5 commits into from
Jul 11, 2022

Conversation

isSerge
Copy link
Contributor

@isSerge isSerge commented Jul 11, 2022

  • Introduces vue-i18n to manage internalization (recommended approach by Vue and Quasar)
  • Removes hardcoded test and replaces it with translations

@isSerge isSerge requested a review from nazar-pc July 11, 2022 08:24
@isSerge isSerge self-assigned this Jul 11, 2022
nazar-pc
nazar-pc approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@nazar-pc nazar-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, but next time would be nice to not have 3rd commit at all and squash first and last together. You can do that cleanly before submitting a PR.

@isSerge isSerge enabled auto-merge (squash) July 11, 2022 10:32
@isSerge isSerge merged commit 407cdf9 into main Jul 11, 2022
@isSerge isSerge deleted the add-internalization branch July 11, 2022 11:05
@isSerge isSerge mentioned this pull request Jul 11, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nazar-pc nazar-pc nazar-pc approved these changes

Assignees

@isSerge isSerge

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isSerge @nazar-pc