Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Logging and small fixes #198

Merged
merged 5 commits into from
May 11, 2022
Merged

Logging and small fixes #198

merged 5 commits into from
May 11, 2022

Conversation

ozgunozerk
Copy link
Contributor

@ozgunozerk ozgunozerk commented May 9, 2022

trivial logging architecture for logging.

useful information for reviewing this PR:

  • it is using a native plugin from tauri team for logging: https://github.com/tauri-apps/tauri-plugin-log
  • backend exposes two new functions for logging to the frontend (1 for error, 1 for info level)
  • frontend uses these exposed functions to relay the error/log messages to backend
  • tauri handles all the process of writing logs to an external file
  • external log file location is not configurable from the end-user perspective. We are using the default ones for macos, linux and windows respectively (actually, tauri-plugin-log is handling these)

I suggest reviewing commit by commit

P.S.
I changed the identifier name from com.tauri.dev to com.subspace.desktop

src/lib/autoLauncher.ts Outdated Show resolved Hide resolved
src-tauri/src/node.rs Show resolved Hide resolved
src/pages/Dashboard.vue Outdated Show resolved Hide resolved
src/pages/SetupPlot.vue Outdated Show resolved Hide resolved
src/lib/util.ts Outdated Show resolved Hide resolved
@ozgunozerk ozgunozerk requested review from nazar-pc and isSerge May 10, 2022 09:30
isSerge
isSerge previously approved these changes May 10, 2022
@ozgunozerk ozgunozerk linked an issue May 10, 2022 that may be closed by this pull request
@ozgunozerk ozgunozerk changed the title Logging Logging and small fixes May 10, 2022
isSerge
isSerge previously approved these changes May 10, 2022
@ozgunozerk ozgunozerk enabled auto-merge May 11, 2022 20:45
@ozgunozerk ozgunozerk merged commit f9ec8b7 into main May 11, 2022
@ozgunozerk ozgunozerk deleted the logging branch May 11, 2022 21:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants