Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ballast in genesis block pseudo-random rather than filled with zeroes #1620

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

nazar-pc
Copy link
Member

@nazar-pc nazar-pc commented Jun 29, 2023

We discussed this in the past. Drawbacks of zeroes include similar pieces and commitments in the very first sector, making it pseudo-random is much better.

Code contributor checklist:

dariolina
dariolina previously approved these changes Jun 29, 2023
liuchengxu
liuchengxu previously approved these changes Jun 29, 2023
Copy link
Contributor

@liuchengxu liuchengxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is sort of a relief to me (the added boilerplate brings in some actual value finally :P)

crates/subspace-service/src/genesis_block_builder.rs Outdated Show resolved Hide resolved
@nazar-pc nazar-pc dismissed stale reviews from liuchengxu and dariolina via 56bfb20 June 29, 2023 09:30
@nazar-pc nazar-pc force-pushed the non-zero-ballast-at-genesis branch from 6d46af6 to 56bfb20 Compare June 29, 2023 09:30
@nazar-pc nazar-pc requested a review from liuchengxu June 29, 2023 09:30
liuchengxu
liuchengxu previously approved these changes Jun 29, 2023
…enesis

# Conflicts:
#	crates/subspace-service/Cargo.toml
@nazar-pc nazar-pc merged commit 2a6550f into main Jun 29, 2023
8 checks passed
@nazar-pc nazar-pc deleted the non-zero-ballast-at-genesis branch June 29, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants