Migrate domain v1 primitives to v2 #1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit include changes of: - remove BundleHeader::operator_id as it is duplicated with ProofOfElection::operator_id - add ExecutionReceipt::domain_block_hash which is needed in the fruad proof - replace Bundle::execution_trace to ExecutionReceipt::execution_trace to store trace on chain - add some misc helper functions Signed-off-by: linning <linningde25@gmail.com>
It will be used later to construct the v2 ExecutionReceipt Signed-off-by: linning <linningde25@gmail.com>
…perator Signed-off-by: linning <linningde25@gmail.com>
Signed-off-by: linning <linningde25@gmail.com>
Signed-off-by: linning <linningde25@gmail.com>
Signed-off-by: linning <linningde25@gmail.com>
Calling Checkable::check before initialize_block will result in AncientBirthBlock error due to some check in CheckMortality::additional_signed, and cause all the extrinsics being filtered out Signed-off-by: linning <linningde25@gmail.com>
…n test Signed-off-by: linning <linningde25@gmail.com>
This test along with test_domain_tx_propagate is disabled due to they are using Call::transfer internally but the evm genesis config is empty and there is no initial balance in the testing account thus these test will failed, leavea a TODO for now will fix in the future. Signed-off-by: linning <linningde25@gmail.com>
Signed-off-by: linning <linningde25@gmail.com>
Signed-off-by: linning <linningde25@gmail.com>
NingLin-P
requested review from
liuchengxu,
vedhavyas,
nazar-pc and
rg3l3dr
as code owners
The __construct_runtime_integrity_test::runtime_integrity_tests test enforce the pallet call enum size should be smaller than 1024 bytes, the submit_fraud_proof call break this limit because the v2 domain header contains a receipt and the bundle equivocation proof contains 2 headers. Signed-off-by: linning <linningde25@gmail.com>
liuchengxu
reviewed
Jul 23, 2023
Signed-off-by: linning <linningde25@gmail.com>
vedhavyas
reviewed
Jul 24, 2023
There was a problem hiding this comment.
Make sense in general. Left some nits. Will look again in sometime
One thing I have noticed is that bunch of these smaller commits would actually make sense when they are merged together. Commits that just adds tests could be part of the commit that introduced the change. I recommend re-reading our contribution guidelines
Commit message is similar but the change they bring is not, the test is an integration test and is not for any single specified commit. |
vedhavyas
approved these changes
Jul 24, 2023
ParthDesai
added a commit
to autonomys/subspace-pulsar-sdk
that referenced
this pull request
Aug 4, 2023
…ace#1684 (minus the domain support)
ParthDesai
added a commit
to autonomys/subspace-pulsar-sdk
that referenced
this pull request
Aug 15, 2023
…ace#1684 (minus the domain support)
ParthDesai
added a commit
to autonomys/subspace-pulsar-sdk
that referenced
this pull request
Aug 15, 2023
…ace#1684 (minus the domain support)
ParthDesai
added a commit
to autonomys/subspace-pulsar-sdk
that referenced
this pull request
Aug 15, 2023
…ace#1684 (minus the domain support)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1676
This migrate domain v1 primitives to v2, including changes of:
BundleandExecutionReceiptin the domain clienthead_receipt_number,oldest_receipt_numberextract_signerruntime API to fix an issue that may filter out all the extrinsic when building domain blockCode contributor checklist: