Enable fraud proof tests #2169
Merged
Enable fraud proof tests #2169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t receipt These runtime api is removed during the domain v2 refactoring, we need to bring them back in order to detect fraudulent ER and submit fraud proof. Noticed, the FruadProofApi is placed in the sp-domains-fraud-proof instead of sp-domains, which is becasue the FraudProof struct is defined in sp-domains-fraud-proof and importing FraudProof to sp-domains will cause cyclic dependency Signed-off-by: linning <linningde25@gmail.com>
The parent chain abstraction is introduced in domain v1 when we have system/core domain, which have different parent chain, since system domain is not present in domain v2, we should remove this abstraction and re-introduce it when system domain is re-introduced. Signed-off-by: linning <linningde25@gmail.com>
Signed-off-by: linning <linningde25@gmail.com>
…id state transition fraud proof Signed-off-by: linning <linningde25@gmail.com>
…neration This commit also move ExtrinsicDigest to sp-domains, otherwise import it in the block-preprocessor will cause cyclic dependency Signed-off-by: linning <linningde25@gmail.com>
This commit enable all fraud proof tests, fix broken tests, and add more checks to the test Signed-off-by: linning <linningde25@gmail.com>
NingLin-P
requested review from
vedhavyas,
nazar-pc and
rg3l3dr
as code owners
Signed-off-by: linning <linningde25@gmail.com>
Since the fraud proof verification is not in the client side anymore Signed-off-by: linning <linningde25@gmail.com>
vedhavyas
reviewed
Nov 6, 2023
1 task
vedhavyas
reviewed
Nov 6, 2023
vedhavyas
reviewed
Nov 7, 2023
Signed-off-by: linning <linningde25@gmail.com>
NingLin-P
force-pushed
the
enable-fraud-proof-test
branch
from
ab9a2a6
to
e22fa0c
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
CI failed due to infra error, try it again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables all the fraud proof tests, and brings some refactoring, necessary infra support, and fix:
Code contributor checklist: