Double check the domain transaction validity before putting it into bundle #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: linning <linningde25@gmail.com>
NingLin-P
requested review from
vedhavyas,
nazar-pc and
rg3l3dr
as code owners
Co-authored-by: Vedhavyas Singareddi <vedhavyas.singareddi@gmail.com>
vedhavyas
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the race condition issue mentioned at #1731 (comment).
Double check the transaction validity, because the tx pool are re-validate the transaction in pool asynchronously so there is a race condition that the operator imported a domain block and starts producing bundle immediately before the re-validation based on the latest block is finished, cause the bundle contains illegal tx accidentally and being considered as invalid bundle and slashing on the honest operator.
I tried to handle #2184 in this PR, but found that it required more work on the illegal tx fraud proof (which is under development by @ParthDesai ) so gave up.
Code contributor checklist: