Enforce the bundles contain ER that derive from the latest domain block #2194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stale type ER is previously used to measure bundle production rate for the dynamic tx range, which is now deprecated so we should reject stale ER. The new branch type ER is rejected, so the honest operator must submit a fraud proof to prune the bad ER at the same height before submitting ER at that height Signed-off-by: linning <linningde25@gmail.com>
This commit change the block tree to use Option to store ER instead of BTreeSet, thus only one ER at a specific height. This change also bring a overhaul to the fraud proof processing and remove some TODO and FIXME Signed-off-by: linning <linningde25@gmail.com>
…instead of CurrentHead In this way we can ensure only ER that derived from the latest domain block will be accepted Signed-off-by: linning <linningde25@gmail.com>
NingLin-P
requested review from
nazar-pc,
rg3l3dr and
vedhavyas
as code owners
vedhavyas
reviewed
Nov 3, 2023
|
Some how github did not let me add one more comment |
Signed-off-by: linning <linningde25@gmail.com>
vedhavyas
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1731
close #1934
This PR implement #1731, to only accept ER that derive from the latest domain block, in this way:
NewBranchER will be rejected and there is only one branch in the block tree right now, an operator must submit fraud proof to prune the bad ER at a specific height before submitting an ER at the same height. This also simplify how fraud proof pruning bad ERThis PR also rejected the Stale ER directly, previously Stale ER is needed to be included in the block body so that we can measure the bundle production rate for the dynamic tx-range adjustment, now since the dynamic tx-range is deprecated, we can reject the Stale ER directly and not include it in the block at all.
Code contributor checklist: