XDM: Accept the fraud proof if the bad receipt marks a non XDM containing bundle as invalid bundle with InvalidXDM #2666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bundle as invalid bundle with InvalidXDM
dastansam
reviewed
Apr 5, 2024
|
LGTM. good move to add a test for this. |
vanhauser-thc
added
audited
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes fraud proof verification for false invalid XDM case.
If a bad receipt marks a bundle with non-XDM extrinsic as Invalid bundle with extrinsic as InvalidXDM, verifier was rejecting the fraud proof. This change will accept the fraud proof when it is a false invalid and challenged extrinsic is not a XDM extrinsic.
closes: #2660
Code contributor checklist: