Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix farm locking Windows #2719

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Fix farm locking Windows #2719

merged 3 commits into from
Apr 26, 2024

Conversation

nazar-pc
Copy link
Member

This PR reverts #2668, adds workaround to support recovery of corrupted farms and adds an alternative to #2668 by locking farm while writing.

The root issue here is Windows again. If file is locked, writes to the file fail with following error:

called `Result::unwrap()` on an `Err` value: Os { code: 33, kind: Uncategorized, message: "The process cannot access the file because another process has locked a portion of the file." }

However, file is still being modified, erased to be specific 🤦

I'm not in the mood right now, but I'll try to create a bug report to Microsoft about this as well.

Code contributor checklist:

@nazar-pc nazar-pc force-pushed the fix-farm-locking-windows branch from 70d4b4b to 35d2cc1 Compare April 25, 2024 23:25
@nazar-pc nazar-pc marked this pull request as draft April 25, 2024 23:32
@nazar-pc nazar-pc force-pushed the fix-farm-locking-windows branch from 35d2cc1 to a4180f9 Compare April 25, 2024 23:37
@nazar-pc nazar-pc marked this pull request as ready for review April 25, 2024 23:37
@nazar-pc nazar-pc enabled auto-merge April 25, 2024 23:37
@nazar-pc nazar-pc changed the title Fix farm locking windows Fix farm locking Windows Apr 25, 2024
@nazar-pc nazar-pc added this pull request to the merge queue Apr 26, 2024
Merged via the queue into main with commit e0b3f7d Apr 26, 2024
9 checks passed
@nazar-pc nazar-pc deleted the fix-farm-locking-windows branch April 26, 2024 00:33
@nazar-pc nazar-pc mentioned this pull request Apr 26, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants