Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Domains: Ensure domain block is extended only once in a consensus block #2790

Merged
merged 1 commit into from
May 24, 2024
Merged

Domains: Ensure domain block is extended only once in a consensus block #2790

merged 1 commit into from
May 24, 2024

Conversation

vedhavyas
Copy link
Contributor

@vedhavyas vedhavyas commented May 24, 2024 •
edited
Loading

This PR ensures domain block is extended only once within a consensus block. This was raised during audit. More here - #2442

Code contributor checklist:

@vedhavyas vedhavyas added the need to audit This change needs to be audited label May 24, 2024
@vedhavyas vedhavyas mentioned this pull request May 24, 2024
Closed
@vedhavyas vedhavyas added this pull request to the merge queue May 24, 2024
Merged via the queue into main with commit 81e4797 May 24, 2024
9 checks passed
@vedhavyas vedhavyas deleted the consecutive_domain_block_number_check branch May 24, 2024 16:56
@vanhauser-thc vanhauser-thc removed the need to audit This change needs to be audited label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NingLin-P NingLin-P NingLin-P approved these changes

@nazar-pc nazar-pc Awaiting requested review from nazar-pc nazar-pc is a code owner

@rg3l3dr rg3l3dr Awaiting requested review from rg3l3dr rg3l3dr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vedhavyas @NingLin-P @vanhauser-thc