Make requests to peers with explicit addresses succeed #3127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazar-pc
force-pushed
the
fix-generic-request-with-addresses
branch
from
64b552e to
55e047d
Compare
nazar-pc
changed the title
teor2345
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #3126 (comment) I decided to write a test case ensuring my assumptions are correct and they were not. I had to hack around it a bit to make things work, but also filed libp2p/rust-libp2p#5634 to potentially improve API going forward.
We're basically caching request after explicit dial with addresses and only handling the request after explicit dial either succeeds or fails.
Code contributor checklist: