Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix request/response with addresses #3145

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

nazar-pc
Copy link
Member

@nazar-pc nazar-pc commented Oct 18, 2024

While previous version worked, it didn't behave nicely during concurrent requests to the same peer due to lack of awareness of pending requests, resulting in this:

2024-10-17T16:55:57.396088Z WARN subspace_networking::node_runner: Failed to dial disconnected peer on generic request error=Dial error: dial condition was configured to only happen when both disconnected (PeerCondition::Disconnected) and there is currently no ongoing dialing attempt (PeerCondition::NotDialing), but node is already connected or dial is in progress, thus cancelling new dial.

While I could fix that with more hacks, I decided to simply patch libp2p while we're discussing it in libp2p/rust-libp2p#5634, here is the patch (subspace-v8 branch): autonomys/rust-libp2p@ae75274

Patch adds addresses argument to send_request method, fixing this issue.

Code contributor checklist:

Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for this cleanup!

(I reviewed the libp2p branch as well.)

@nazar-pc nazar-pc enabled auto-merge October 18, 2024 06:32
@nazar-pc nazar-pc added this pull request to the merge queue Oct 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 18, 2024
@nazar-pc nazar-pc merged commit 70178b8 into main Oct 18, 2024
10 checks passed
@nazar-pc nazar-pc deleted the fix-request-response-with-addresses branch October 18, 2024 08:36
@nazar-pc nazar-pc mentioned this pull request Nov 4, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants