Keep our customized executive pallet up-to-date with the upstream #3186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is broken, incomplete, and unused, we can add it back when we have use case. Signed-off-by: linning <linningde25@gmail.com>
Signed-off-by: linning <linningde25@gmail.com>
nazar-pc
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings some changes to our customized executive pallet to keep it up-to-date with the upstream, this fixes the
state_traceBlockRPC service cc @DaMandal0rian. Note these changes don't affect the actual domain block execution but only the cli and RPC because all the domain blocks are derived locally with the domain block builder whose logic is untouched.Ideally, we should proceed with paritytech/substrate#10711 to remove the need of maintaining our customized executive pallet but things get more complicated now because we do not just need a hook to collect the intermediate storage root but also some customized behavior of
apply_extrinsic(introduced in #2343).This PR also removes the
try-runtimefeature which is broken, incomplete, and unused, we can add it back when we have a use case.Code contributor checklist: