Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gateway to snapshot builds in CI #3256

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Add gateway to snapshot builds in CI #3256

merged 1 commit into from
Nov 26, 2024

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Nov 25, 2024

This PR adds subspace-gateway to snapshot builds.

Test build here (including #3257): https://github.com/autonomys/subspace/actions/runs/12022336058

Code contributor checklist:

@teor2345 teor2345 self-assigned this Nov 25, 2024
@teor2345 teor2345 enabled auto-merge November 25, 2024 23:22
@teor2345 teor2345 mentioned this pull request Nov 25, 2024
44 tasks
@@ -104,7 +107,6 @@ jobs:
cd executables
IMAGE="${{ fromJSON(steps.meta.outputs.json).tags[0] }}"
ARTIFACT="${{ matrix.build.base-artifact }}"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It set off my editor's trailing spaces auto-formatting.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing trailing spaces is good, but this one got the whole line itself removed. It is fine.

docker/gateway.Dockerfile.dockerignore Outdated Show resolved Hide resolved
Copy link
Contributor Author

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The symlink should be fixed now, happy to revert the empty line change too if you want.

@@ -104,7 +107,6 @@ jobs:
cd executables
IMAGE="${{ fromJSON(steps.meta.outputs.json).tags[0] }}"
ARTIFACT="${{ matrix.build.base-artifact }}"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It set off my editor's trailing spaces auto-formatting.

docker/gateway.Dockerfile.dockerignore Outdated Show resolved Hide resolved
@@ -104,7 +107,6 @@ jobs:
cd executables
IMAGE="${{ fromJSON(steps.meta.outputs.json).tags[0] }}"
ARTIFACT="${{ matrix.build.base-artifact }}"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing trailing spaces is good, but this one got the whole line itself removed. It is fine.

@teor2345 teor2345 added this pull request to the merge queue Nov 26, 2024
Merged via the queue into main with commit ab68451 Nov 26, 2024
8 checks passed
@teor2345 teor2345 deleted the gateway-docker branch November 26, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants