Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARCH_EDITION removed a href="?(praat\d+_mac.dmg)"? #369

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

PeetMcK
Copy link
Contributor

@PeetMcK PeetMcK commented Nov 22, 2020

Update the URLTextSearcher re_pattern .... looks like the link no longer includes %ARCH_EDITION%. i.e. the link is currently https://www.fon.hum.uva.nl/praat/praat6133_mac.dmg so ... a href="?(praat\d+_mac.dmg)"? ... should work.

Update the URLTextSearcher re_pattern .... looks like the link no longer includes %ARCH_EDITION%.  i.e. the link is currently https://www.fon.hum.uva.nl/praat/praat6133_mac.dmg ... so a href="?(praat\d+_mac.dmg)"? ... should work.
Copy link
Contributor

@jc0b jc0b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change works for me. I think we could remove the ARCH argument as well, as I don't imagine there are too many people out there still managing machines that only support 32-bit applications.

Processing Praat.download.recipe...
WARNING: Praat.download.recipe is missing trust info and FAIL_RECIPES_WITHOUT_TRUST_INFO is not set. Proceeding...
URLTextSearcher
URLTextSearcher: Found matching text (dl_filename): praat6133_mac.dmg
URLDownloader
URLDownloader: Storing new Last-Modified header: Thu, 19 Nov 2020 13:42:14 GMT
URLDownloader: Storing new ETag header: "15b68b4-5b475e5417980"
URLDownloader: Downloaded /Users/jc0b/Library/AutoPkg/Cache/com.github.autopkg.download.Praat/downloads/Praat.dmg
EndOfCheckPhase
CodeSignatureVerifier
CodeSignatureVerifier: Mounted disk image /Users/jc0b/Library/AutoPkg/Cache/com.github.autopkg.download.Praat/downloads/Praat.dmg
CodeSignatureVerifier: Verifying code signature...
CodeSignatureVerifier: Deep verification enabled...
CodeSignatureVerifier: Strict verification not defined. Using codesign defaults...
CodeSignatureVerifier: /private/tmp/dmg.hy1RNF/Praat.app: valid on disk
CodeSignatureVerifier: /private/tmp/dmg.hy1RNF/Praat.app: satisfies its Designated Requirement
CodeSignatureVerifier: /private/tmp/dmg.hy1RNF/Praat.app: explicit requirement satisfied
CodeSignatureVerifier: Signature is valid
Receipt written to /Users/jc0b/Library/AutoPkg/Cache/com.github.autopkg.download.Praat/receipts/Praat.download-receipt-20201122-180148.plist

The following new items were downloaded:
    Download Path                                                                            
    -------------                                                                            
    /Users/jc0b/Library/AutoPkg/Cache/com.github.autopkg.download.Praat/downloads/Praat.dmg```

Copy link

@Tinellmann1979 Tinellmann1979 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warnings

@PeetMcK
Copy link
Contributor Author

PeetMcK commented Dec 11, 2020

Warnings? Not sure what you're saying.

@nmcspadden nmcspadden merged commit 5db796b into autopkg:master Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants