Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

970 imgaug workaround mock augmentations #978

Merged
merged 3 commits into from
Jan 14, 2022

Conversation

Ezward
Copy link
Contributor

@Ezward Ezward commented Jan 10, 2022

Issue #970

Currently uses of Jetson Nano that use image augmentations or tranformations AND want to train on their Nano will get an exception because imgaug is not installed. It is not installed because it conflicts with opencv, which is required for the CSIC camera. The maintainer of imgaug has stated in related issues in the imgaug repo that he will not be fixing this.

This is a temporary hack to mock our ImageAugmentation class if imgaug cannot be imported. This is a workaround so users of the Jetson Nano can train even if imgaug is not installed. This allows them to train on their nano even if imgaug is not installed.

- this is a workaround for issue 970
- #970
- it is meant to be temporary until we refactor
  the image augmentations to not use imgaug
@Ezward Ezward self-assigned this Jan 10, 2022
@Ezward
Copy link
Contributor Author

Ezward commented Jan 10, 2022

For discussion: this is implemented to allow users to specify augmentations and transformations, but to ignore them. We might want to throw an error instead and instruct them to remove the augmentations and/or transformations.

@Ezward Ezward changed the title 970 imgaug workaround mock augmenations 970 imgaug workaround mock augmentations Jan 10, 2022
Copy link
Contributor

@DocGarbanzo DocGarbanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@DocGarbanzo DocGarbanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect.

@Ezward
Copy link
Contributor Author

Ezward commented Jan 14, 2022

It failed Python package and test / set up python 3.7 (ubuntu-latest, install/envs/ubuntu.yml) (push) because of the conda bug; github eventually cancels the test. This is preventing me from merging.

@DocGarbanzo DocGarbanzo merged commit a3df79a into dev Jan 14, 2022
@Ezward Ezward deleted the 970-imgaug-workaround-mock-augmenations branch January 15, 2022 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants