-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(autoware-interfaces): fix description of base link #164
docs(autoware-interfaces): fix description of base link #164
Conversation
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
docs/design/autoware-interfaces/components/vehicle-dimensions.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Lalith Vipulananthan <lalith.vipulananthan@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, but one of the other reviewers should check the wording and approve.
@YamatoAndo, @mitsudome-r, @xmfcx - could you review the proposed change and confirm whether it is acceptable or not please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late reply.
LGTM.
@isamu-takagi @mitsudome-r @YamatoAndo I've just realized that base_link was actually projected to the ground. Is there a reason why this convention is used instead of center of the rear axle? |
@xmfcx
|
Signed-off-by: Takagi, Isamu isamu.takagi@tier4.jp
Description
Fix description of base link.
https://autowarefoundation.github.io/autoware-documentation/main/design/autoware-architecture/localization/#tf-tree
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The Reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.