Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(autoware-interfaces): fix description of base link #164

Merged
merged 2 commits into from
Sep 14, 2022

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Jul 13, 2022

Signed-off-by: Takagi, Isamu isamu.takagi@tier4.jp

Description

Fix description of base link.
https://autowarefoundation.github.io/autoware-documentation/main/design/autoware-architecture/localization/#tf-tree

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@kenji-miyake kenji-miyake requested a review from a user July 13, 2022 07:38
Signed-off-by: Lalith Vipulananthan <lalith.vipulananthan@tier4.jp>

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, but one of the other reviewers should check the wording and approve.

@YamatoAndo, @mitsudome-r, @xmfcx - could you review the proposed change and confirm whether it is acceptable or not please?

Copy link
Contributor

@YamatoAndo YamatoAndo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply.
LGTM.

@kenji-miyake kenji-miyake enabled auto-merge (squash) September 14, 2022 06:58
@kenji-miyake kenji-miyake merged commit 6222eb2 into autowarefoundation:main Sep 14, 2022
@kenji-miyake kenji-miyake deleted the fix/base-link-description branch September 14, 2022 07:03
@xmfcx
Copy link
Contributor

xmfcx commented Sep 7, 2023

@isamu-takagi @mitsudome-r @YamatoAndo I've just realized that base_link was actually projected to the ground. Is there a reason why this convention is used instead of center of the rear axle?

@isamu-takagi
Copy link
Contributor Author

@xmfcx
I think the definition used when Autoware was first released are used as it is.
I don't know how it came about, but maybe from following benefits:

  • Since the height is often calculated based on the ground, there is no need to calculate the wheel radius.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants