Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tutorial): add -y for rosdep and fix markdown link #201

Merged
merged 2 commits into from
Sep 20, 2022

Conversation

evshary
Copy link
Member

@evshary evshary commented Sep 20, 2022

Description

Add -y to rosdep install -y --from-paths src --ignore-src --rosdistro $ROS_DISTRO,
which is in the installation of Scenario simulation tutorial.

This can avoid too many annoying installation checkings.

Also fix the markdown link in the tutorial.

image

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: ChenYing Kuo <chenying.kuo@adlinktech.com>
Signed-off-by: ChenYing Kuo <chenying.kuo@adlinktech.com>
@evshary
Copy link
Member Author

evshary commented Sep 20, 2022

A little off-topic, I failed to run the Ad hoc simulation and Scenario simulation with the latest Autoware version in the tutorial.
Should I ask the question directly in GitHub Discussion?

@kenji-miyake
Copy link
Contributor

@evshary Thank you for your PR! 😄

A little off-topic, I failed to run the Ad hoc simulation and Scenario simulation with the latest Autoware version in the tutorial.
Should I ask the question directly in GitHub Discussion?

Yes, it's great.
But it might be resolved now. Could you update the workspace and retry it, please?
autowarefoundation/autoware.universe#1907

@kenji-miyake kenji-miyake changed the title fix(tutorial): Add -y for rosdep and fix markdown link fix(tutorial): add -y for rosdep and fix markdown link Sep 20, 2022
@kenji-miyake kenji-miyake enabled auto-merge (squash) September 20, 2022 09:00
@kenji-miyake kenji-miyake merged commit d9760e6 into autowarefoundation:main Sep 20, 2022
@evshary evshary deleted the minor_fix branch September 20, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants