Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deploy-docs): fix latest condition #55

Merged

Conversation

KeisukeShima
Copy link
Contributor

Related autowarefoundation/autoware-github-actions#96

Added a condition for latest to correct a malfunction in pull_request_target.

Signed-off-by: Keisuke Shima 19993104+KeisukeShima@users.noreply.github.com

kenji-miyake
kenji-miyake previously approved these changes Mar 14, 2022
Copy link
Contributor

@kenji-miyake kenji-miyake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested this?
Please add your test result or some reference links to the description.

@KeisukeShima KeisukeShima added the type:documentation Creating or refining documentation. label Mar 14, 2022
@github-actions
Copy link

Documentation URL: https://autowarefoundation.github.io/autoware-documentation/pr-55/
Modified URLs:

@kenji-miyake
Copy link
Contributor

Unfortunately, I think you can't test this in this PR because it's pull_request_target.

@KeisukeShima
Copy link
Contributor Author

Unfortunately, I think you can't test this in this PR because it's pull_request_target.

First, I tried to display the variables, but they are not displayed...
5ccfa6c

@KeisukeShima
Copy link
Contributor Author

Unfortunately, I think you can't test this in this PR because it's pull_request_target.

So the script is executed before the change. Understood.
But at least the contents of the variable should be displayed, right?

@kenji-miyake
Copy link
Contributor

@KeisukeShima Hmm? What do you mean?
(If necessary, you can write your comments both in Japanese and English.)

@KeisukeShima
Copy link
Contributor Author

@KeisukeShima Hmm? What do you mean? (If necessary, you can write your comments both in Japanese and English.)

So the script is executed before the change. Understood.
But at least the contents of the variable should be displayed, right?
変更前のスクリプトが実行されるということですね。理解しました。
しかし、少なくとも変数の内容が表示されてもいいはずですよね。

という内容です

@KeisukeShima
Copy link
Contributor Author

Note: The pull_request_target event does not reflect script changes 😇

@KeisukeShima KeisukeShima removed the type:documentation Creating or refining documentation. label Mar 14, 2022
@KeisukeShima
Copy link
Contributor Author

image
https://github.com/KeisukeShima/autoware-documentation/runs/5536759468?check_suite_focus=true

Variable values are as expected!

kenji-miyake
kenji-miyake previously approved these changes Mar 14, 2022
@kenji-miyake kenji-miyake enabled auto-merge (squash) March 14, 2022 12:08
Signed-off-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
Signed-off-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
Signed-off-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
Signed-off-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
This reverts commit c65497d.

Signed-off-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
This reverts commit 5ccfa6c.

Signed-off-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
@kenji-miyake kenji-miyake merged commit b3b8460 into autowarefoundation:main Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants