Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(update-codeowners-from-packages): support global codeowners #194

Merged
merged 2 commits into from
Nov 17, 2022

Conversation

kenji-miyake
Copy link
Contributor

@kenji-miyake kenji-miyake commented Nov 17, 2022

Description

@xmfcx wants global codeowners to bypass reviews safely.
Currently, bypassing reviews isn't supported as we desire.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
@kenji-miyake kenji-miyake requested a review from xmfcx November 17, 2022 15:00
@kenji-miyake kenji-miyake marked this pull request as draft November 17, 2022 15:03
Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(as a reminder)

inputs.global-codeowners = @autowarefoundation/autoware-global-codeowners

for https://github.com/orgs/autowarefoundation/teams/autoware-global-codeowners/members

fix
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
@kenji-miyake kenji-miyake marked this pull request as ready for review November 17, 2022 15:15
@kenji-miyake kenji-miyake merged commit 242ab25 into main Nov 17, 2022
@kenji-miyake kenji-miyake deleted the support-global-owners branch November 17, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants