fix(test-composite-actions): use newer ghcr image #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The last update of the image (ghcr.io/autowarefoundation/autoware-universe:humble-latest)
was 6 months ago
* Before this fix, the workflow was failing with following error:
```
Error response from daemon: Head "https://ghcr.io/v2/autowarefoundation/autoware-universe/manifests/humble-latest": unauthorized
```
Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
xmfcx
approved these changes
Sep 5, 2024
youtalk
reviewed
Sep 5, 2024
| @@ -146,7 +146,8 @@ jobs: | |||
| matrix: | |||
| container: | |||
| - ros:humble | |||
| - ghcr.io/autowarefoundation/autoware-universe:humble-latest | |||
| - ghcr.io/autowarefoundation/autoware:latest-autoware-universe | |||
There was a problem hiding this comment.
Suggested change
| - ghcr.io/autowarefoundation/autoware:latest-autoware-universe | |
| - ghcr.io/autowarefoundation/autoware:latest-universe-devel |
is better from today.
autowarefoundation/autoware#5170
sasakisasaki
added a commit
that referenced
this pull request
Sep 5, 2024
This reverts commit a173e01.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix not to use outdated image in the workflow.
Related links
Not provided.
Tests performed (edited)
The target workflow is now functional. I believe this is enough as testing.
Notes for reviewers (edited)
Before this fix, the workflow
test-get-self-packages-and-get-modified-packageswas failing with following error.Interface changes
No interface change exists in this PR
ROS Topic Changes
No change exists in this PR.
ROS Parameter Changes
No change exists in this PR.
Effects on system behavior
The failing workflow
test-composite-actionswill succeed.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.