Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(github-runner): fix to use ubuntu-22.04 #324

Conversation

sasakisasaki
Copy link
Contributor

@sasakisasaki sasakisasaki commented Oct 11, 2024

Description

Fixes to use Ubuntu 22.04 OS on the Girhub actions.

Related links

Ubuntu-latest workflows will use Ubuntu-24.04 image

Tests performed

Will be updated after the PR author checks if the change works.

Verified that using ubuntu-22.04 works by watching running actions with runs-on: ubuntu-22.04.

Notes for reviewers

Nothing to note here.

Interface changes

No change in this PR.

ROS Topic Changes

No ROS topic change in this PR.

ROS Parameter Changes

No ROS parameter changes in this PR.

Effects on system behavior

The Github actions will run as up to now.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

  * It seems the default OS has changed from ubuntu-22.04 to ubuntu-24.04
    somewhere on the beginning of Oct. 2024
  * To prevent from the unexpected fixes for a while, keep using ubuntu-22.04

Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
  * It seems the default OS will change from ubuntu-22.04 to ubuntu-24.04
    around on 30th Oct. 2024
    (Ref. actions/runner-images#10636)
  * To prevent from the unexpected fixes for a while, keep using ubuntu-22.04

Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
@sasakisasaki sasakisasaki changed the title fix(github-runner): fix to use ubuntu-22.04 (see below) fix(github-runner): fix to use ubuntu-22.04 Oct 11, 2024
@sasakisasaki sasakisasaki marked this pull request as ready for review October 11, 2024 10:23
@sasakisasaki sasakisasaki merged commit f135730 into autowarefoundation:main Oct 11, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants