-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(require-label): add new reusable workflow #331
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: M. Fatih Cırıt <mfc@autoware.org>
Signed-off-by: M. Fatih Cırıt <mfc@autoware.org>
Signed-off-by: M. Fatih Cırıt <mfc@autoware.org>
Signed-off-by: M. Fatih Cırıt <mfc@autoware.org>
Signed-off-by: M. Fatih Cırıt <mfc@autoware.org>
Signed-off-by: M. Fatih Cırıt <mfc@autoware.org>
mitsudome-r
reviewed
Dec 24, 2024
sasakisasaki
approved these changes
Dec 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick Comment
Looks good!
Reason for Approval
The workflow has two main features: success and failure cases. The PR description shows that the both features are tested well.
Signed-off-by: M. Fatih Cırıt <mfc@autoware.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🤔 We have make-sure-label-is-present.yaml but it skips when it cannot find the label and let's the remaining actions decide what to do with the result. Because it doesn't fail, it skips the remaining workflows.
🫤 We also have prevent-no-label-execution.yaml which has the identical behavior. But this one is only here for legacy reasons, it can get confused when multiple labels are added at the same time.
So we needed a workflow that actually fails when the input label is not present.
require-label
workflow does just that. It's a slightly modified version of make-sure-label-is-present.yaml but with additional summary and useful debug output.Tests performed
Failure
Success
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.