Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(require-label): add new reusable workflow #331

Merged
merged 7 commits into from
Dec 24, 2024
Merged

ci(require-label): add new reusable workflow #331

merged 7 commits into from
Dec 24, 2024

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Dec 23, 2024

Description

🤔 We have make-sure-label-is-present.yaml but it skips when it cannot find the label and let's the remaining actions decide what to do with the result. Because it doesn't fail, it skips the remaining workflows.

🫤 We also have prevent-no-label-execution.yaml which has the identical behavior. But this one is only here for legacy reasons, it can get confused when multiple labels are added at the same time.

So we needed a workflow that actually fails when the input label is not present.

require-label workflow does just that. It's a slightly modified version of make-sure-label-is-present.yaml but with additional summary and useful debug output.

Tests performed

Failure

image

image

Success

image

image

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: M. Fatih Cırıt <mfc@autoware.org>
Signed-off-by: M. Fatih Cırıt <mfc@autoware.org>
Signed-off-by: M. Fatih Cırıt <mfc@autoware.org>
Signed-off-by: M. Fatih Cırıt <mfc@autoware.org>
Signed-off-by: M. Fatih Cırıt <mfc@autoware.org>
Signed-off-by: M. Fatih Cırıt <mfc@autoware.org>
Copy link
Contributor

@sasakisasaki sasakisasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick Comment

Looks good!

Reason for Approval

The workflow has two main features: success and failure cases. The PR description shows that the both features are tested well.

Signed-off-by: M. Fatih Cırıt <mfc@autoware.org>
@xmfcx
Copy link
Contributor Author

xmfcx commented Dec 24, 2024

Applied ubuntu-latest and tested on the last job:

image

@xmfcx xmfcx merged commit 7d05dce into main Dec 24, 2024
12 of 13 checks passed
@xmfcx xmfcx deleted the ci/require-label branch December 24, 2024 09:04
@xmfcx xmfcx self-assigned this Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants