-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sometimes the sensing module doesn't publish concatenated pointcloud #1009
Comments
Could you confirm that the requested plugins above are in the list which is shown with |
@wep21 This is the result of |
@yukkysaito Could you confirm that |
I tried launching the sensing module 10 times each on 2 PCs, but have not been able to reproduce it here |
We will wait another week for further reports if any other developers can reproduce the error. |
I'll look into this as well |
@yukkysaito how are you launching the sensing module? Separately via |
@yukkysaito I've been able to launch autoware via |
@esteve I launch it following the tutorial |
@yukkysaito When this error happens, if you restart the computer, does it start working again? |
@yukkysaito ping |
Hi, I recently started to have this very error using Although the message seems to point out there is an issue with the plugin, it seems to me the problem appears when the plugin is tried to be loaded before the container is actually started. The way I have found to fix that problem is to move the launch of the container from Like this <?xml version="1.0" encoding="UTF-8"?>
<launch>
<!-- Pointcloud container -->
<arg name="pointcloud_container_name" default="pointcloud_container"/>
<group>
<include file="$(find-pkg-share autoware_launch)/launch/pointcloud_container.launch.py">
<arg name="use_multithread" value="true"/>
<arg name="container_name" value="$(var pointcloud_container_name)"/>
</include>
</group>
</launch> |
We should further investigate why this happens in https://github.com/autowarefoundation/sample_sensor_kit_launch/blob/main/sample_sensor_kit_launch/launch/pointcloud_preprocessor.launch.py Also we need to test and see if it happens in humble too. |
The reason why this happens is because sensing.launch and perception.launch could start before the pointcloud container start, I think. |
yes |
@miursh is right, here is the launch call graph. It is absolutely too complicated and parameters passed around are basically a mess. It's very tedious to figure out where a parameter is set when the launch file graph is this deep. What I figured out is,
How do we fix this?
I just don't like current launch system of Autoware. How can we make it better, I don't have an answer yet. |
|
Here is some test snippets. You can see burger image regardless of the launch order.
|
@wep21 were you able to reproduce this issue? For me this error occurs 80% of the times I run the logging simulator launch file, do you know why it might be happening like this then? |
I can't reproduce the issue, but from the log my colleague shared, I guess some components which are supposed to exist aren't found as below.
|
I made the environment to reproduce this and am debugging, but still can't figure it out. |
@miursh is off for a week and won't be able to work on this until next week. |
I'm looking for the root cause, but there might not be a quick fix. |
I'm sorry I couldn't find enough time to work for this. |
We find a way how to reproduce the issue. On my PC with 8 cores / 16 threads CPU when I'm running the command
and then autoware, the issue almost always appears. Without |
During debugging I noticed that launch sequence is not a root cause. For whatever reason, when the failure occurs when
When
The main question is what determines the order of loading .so modules? |
@lchojnack can you check if this #1982 solves this issue? |
…t_path fix(lane_change): do not cut abort path
…ts (autowarefoundation#1009) Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Checklist
Description
sometimes the sensing module cannot launch concatenated and cropbox filter with the following error
Expected behavior
launch concatenated and cropbox filter without error
Actual behavior
launch concatenated and cropbox filter without error
Steps to reproduce
play rosbag replay simulator in tutorials
Versions
No response
Possible causes
No response
Additional context
No response
Temporary fix
The text was updated successfully, but these errors were encountered: