fix(autoware_pointcloud_preprocessor): fix potential double unlock in concatenate node #10082
+61
−79
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
succeeded
Feb 21, 2025 in 38s
CodeScene PR Check
Quality Gate Passed
(1 files improve in Code Health)
Gates Passed
See analysis details in CodeScene
View Improvements
| File | Code Health Impact | Categories Improved |
|---|---|---|
| concatenate_and_time_sync_node.cpp | 6.76 → 7.06 | Complex Method, Bumpy Road Ahead, Overall Code Complexity, Deep, Nested Complexity |
Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
Details
✅ Improving Code Health:
- Overall Code Complexity concatenate_and_time_sync_node.cpp
- Complex Method concatenate_and_time_sync_node.cpp: PointCloudConcatenateDataSynchronizerComponent::manage_collector_list
- Deep, Nested Complexity concatenate_and_time_sync_node.cpp: PointCloudConcatenateDataSynchronizerComponent::manage_collector_list
- Bumpy Road Ahead concatenate_and_time_sync_node.cpp: PointCloudConcatenateDataSynchronizerComponent::manage_collector_list
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Method
PointCloudConcatenateDataSynchronizerComponent::manage_collector_list is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Bumpy Road Ahead
PointCloudConcatenateDataSynchronizerComponent::manage_collector_list is no longer above the threshold for logical blocks with deeply nested code. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 6.42 to 6.00, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Deep, Nested Complexity
PointCloudConcatenateDataSynchronizerComponent::manage_collector_list is no longer above the threshold for nested complexity depth. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.
Loading