Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_image_projection_based_fusion): modify incorrect index access in pointcloud filtering for out-of-range points #10087

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

keita1523
Copy link

@keita1523 keita1523 commented Feb 10, 2025

Description

Before
In this line, the point cloud filtering process for out-of-range points increments output variables (such as "iter_painted_x") at the same time as "iter_x".
However, in the following process, these output variables are used until "j", which is the size of points within the range.
As a result, data is stored at indices beyond "j", leading to incorrect index access.

After
I modified the timing of the increments for "iter_painted_x" so that points within the range are stored correctly until "j".

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: keita1523 <keita.miura@tier4.jp>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Feb 10, 2025
Copy link

github-actions bot commented Feb 10, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@technolojin technolojin self-assigned this Feb 10, 2025
@technolojin technolojin self-requested a review February 10, 2025 05:32
@technolojin technolojin assigned keita1523 and unassigned technolojin Feb 10, 2025
@keita1523 keita1523 changed the title fix(autoware_image_projection_based_fusion): modify fix(autoware_image_projection_based_fusion): modify incorrect index access in pointcloud filtering for out of range points Feb 11, 2025
@keita1523 keita1523 changed the title fix(autoware_image_projection_based_fusion): modify incorrect index access in pointcloud filtering for out of range points fix(autoware_image_projection_based_fusion): modify incorrect index access in pointcloud filtering for out-of-range points Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

2 participants