Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tier4_perception_launch): re-order objects_validation process after lidar ml detector #10160

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

technolojin
Copy link
Contributor

@technolojin technolojin commented Feb 19, 2025

Description

  1. Re-order so-called "objects_validation" process after lidar ml detector.
  • Before
    [Lider-ML detector] -> [roi detected object fusion] -> [object validator] -> [merger]
  • After
    [Lider-ML detector] -> [object validator] -> [roi detected object fusion] -> [merger]

This change do not induce the documentation diagram change.
https://github.com/autowarefoundation/autoware-documentation/blob/main/docs/design/autoware-architecture/perception/image/reference-implementaion-perception-diagram.drawio.svg

  1. Refactoring camera-lidar detector.launch.xml

No logical changes introduced in this PR.

Related links

Parent Issue:

  • Link

How was this PR tested?

TIER IV INTERNAL
test 1 check various mode combinations
test 2 performance test

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Feb 19, 2025
Copy link

github-actions bot commented Feb 19, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@technolojin technolojin changed the title chore(tier4_perception_launch): centerpoint filter valid pipeline chore(tier4_perception_launch): re-order objects_validation process after lidar ml detector Feb 19, 2025
@technolojin technolojin self-assigned this Feb 19, 2025
@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 19, 2025
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…nd related logic

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…radar merger launch files

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…pe estimation

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…ect ROI filter

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin technolojin force-pushed the fix/centerpoint-filter-valid-pipeline branch from a48c74c to d433b39 Compare February 19, 2025 06:05
@technolojin technolojin marked this pull request as ready for review February 19, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

1 participant