Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: replace reusable workflows with composite actions #104

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 31 additions & 22 deletions .github/workflows/build-and-test-pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,28 +4,37 @@ on:
pull_request:

jobs:
get-modified-packages:
uses: autowarefoundation/autoware-github-actions/.github/workflows/reusable-get-modified-packages.yaml@6a086d5eac5effbed9876049233213f5cd358914
with:
script-ref: 6a086d5eac5effbed9876049233213f5cd358914

get-modified-source-files:
uses: autowarefoundation/autoware-github-actions/.github/workflows/reusable-get-modified-source-files.yaml@6a086d5eac5effbed9876049233213f5cd358914

build-and-test:
needs: get-modified-packages
uses: autowarefoundation/autoware-github-actions/.github/workflows/reusable-colcon-build-and-test.yaml@6a086d5eac5effbed9876049233213f5cd358914
with:
rosdistro: galactic
build-depends-repos: build_depends.repos
target-packages: ${{ needs.get-modified-packages.outputs.modified-packages }}
runs-on: ubuntu-latest
container: ros:galactic
steps:
- name: Get modified packages
id: get-modified-packages
uses: autowarefoundation/autoware-github-actions/get-modified-packages@tier4/proposal

- name: Build and test
if: ${{ steps.get-modified-packages.outputs.modified-packages != '' }}
id: build-and-test
uses: autowarefoundation/autoware-github-actions/colcon-build-and-test@tier4/proposal
with:
rosdistro: galactic
target-packages: ${{ steps.get-modified-packages.outputs.modified-packages }}
build-depends-repos: build_depends.repos

clang-tidy:
needs: [get-modified-source-files, build-and-test]
uses: autowarefoundation/autoware-github-actions/.github/workflows/reusable-clang-tidy.yaml@6a086d5eac5effbed9876049233213f5cd358914
with:
script-ref: 6a086d5eac5effbed9876049233213f5cd358914
rosdistro: galactic
build-depends-repos: build_depends.repos
target-files: ${{ needs.get-modified-source-files.outputs.modified-source-files }}
compile-commands-hash: ${{ needs.build-and-test.outputs.compile-commands-hash }}
runs-on: ubuntu-latest
container: ros:galactic
needs: build-and-test
steps:
- name: Get modified packages
id: get-modified-packages
uses: autowarefoundation/autoware-github-actions/get-modified-packages@tier4/proposal

- name: Run clang-tidy
if: ${{ steps.get-modified-source-files.outputs.modified-source-files != '' }}
uses: autowarefoundation/autoware-github-actions/clang-tidy@tier4/proposal
with:
rosdistro: galactic
target-packages: ${{ steps.get-modified-packages.outputs.modified-packages }}
clang-tidy-config-url: https://raw.githubusercontent.com/autowarefoundation/autoware-github-actions/tier4/proposal/.clang-tidy
build-depends-repos: build_depends.repos
35 changes: 17 additions & 18 deletions .github/workflows/build-and-test-scheduled.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,22 +6,21 @@ on:
workflow_dispatch:

jobs:
get-self-packages:
uses: autowarefoundation/autoware-github-actions/.github/workflows/reusable-get-self-packages.yaml@6a086d5eac5effbed9876049233213f5cd358914
build-and-test-scheduled:
runs-on: ${{ matrix.os }}
container: ros:galactic
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, ARM64]
steps:
- name: Get self packages
id: get-self-packages
uses: autowarefoundation/autoware-github-actions/get-self-packages@tier4/proposal

build-and-test:
needs: get-self-packages
uses: autowarefoundation/autoware-github-actions/.github/workflows/reusable-colcon-build-and-test.yaml@6a086d5eac5effbed9876049233213f5cd358914
with:
rosdistro: galactic
build-depends-repos: build_depends.repos
target-packages: ${{ needs.get-self-packages.outputs.self-packages }}

build-and-test-arm64:
needs: get-self-packages
uses: autowarefoundation/autoware-github-actions/.github/workflows/reusable-colcon-build-and-test.yaml@6a086d5eac5effbed9876049233213f5cd358914
with:
os: ARM64
rosdistro: galactic
build-depends-repos: build_depends.repos
target-packages: ${{ needs.get-self-packages.outputs.self-packages }}
- name: Build and test
uses: autowarefoundation/autoware-github-actions/colcon-build-and-test@tier4/proposal
with:
rosdistro: galactic
build-depends-repos: build_depends.repos
target-packages: ${{ steps.get-self-packages.outputs.self-packages }}
34 changes: 0 additions & 34 deletions .github/workflows/generate-docs.yaml

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/semantic-pull-request.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@ on:

jobs:
semantic-pull-request:
uses: autowarefoundation/autoware-github-actions/.github/workflows/reusable-semantic-pull-request.yaml@6a086d5eac5effbed9876049233213f5cd358914
uses: autowarefoundation/autoware-github-actions/.github/workflows/semantic-pull-request.yaml@tier4/proposal
secrets:
token: ${{ secrets.GITHUB_TOKEN }}
12 changes: 9 additions & 3 deletions .github/workflows/spell-check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ on:

jobs:
spell-check:
uses: autowarefoundation/autoware-github-actions/.github/workflows/reusable-spell-check.yaml@6a086d5eac5effbed9876049233213f5cd358914
with:
cspell-json-url: https://raw.githubusercontent.com/tier4/autoware-spell-check-dict/main/cspell/.cspell.json
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v2

- name: Run spell-check
uses: autowarefoundation/autoware-github-actions/spell-check@tier4/proposal
with:
cspell-json-url: https://raw.githubusercontent.com/tier4/autoware-spell-check-dict/main/cspell/.cspell.json
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,5 @@
This is one of the prototype repositories for Autoware Core/Universe that AWF agreed to create in the [TSC meeting on 2021/11/17](https://discourse.ros.org/t/technical-steering-committee-tsc-meeting-36-2021-11-17-minutes/23168).

Please see [autowarefoundation/autoware](https://github.com/autowarefoundation/autoware) for more details.

---
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ double calcBrakingDistance(
return (abs_velocity * abs_velocity) / (2.0 * max_deceleration) + delay_time * abs_velocity;
}

bool isInAnyLane(const lanelet::ConstLanelets & candidate_lanelets, const Point2d & point)
bool isInAnyLane(const lanelet::ConstLanelets & candidate_lanelets, const Point2d point)
{
for (const auto & ll : candidate_lanelets) {
if (boost::geometry::within(point, ll.polygon2d().basicPolygon())) {
Expand Down