Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(occupancy_grid_map_outlier_filter): migrate to point_cloud_msg_wrapper #1352

Closed

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Jul 14, 2022

Description

This PR replaces the standard point cloud iterators from the sensor_msgs package with Point Cloud Message Wrapper

Related links

#1199

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@stale
Copy link

stale bot commented Sep 13, 2022

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Sep 13, 2022
@xmfcx xmfcx self-requested a review September 20, 2022 16:22
@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Sep 20, 2022
@xmfcx xmfcx requested review from kaancolak and removed request for aohsato, yukkysaito, xmfcx, kenji-miyake and miursh October 4, 2022 15:58
esteve and others added 2 commits October 6, 2022 12:49
…rapper

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve esteve force-pushed the point-cloud-msg-wrapper-ocupancy-grid-map-outlier-filter branch from c3452c9 to 620642d Compare October 6, 2022 10:49
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kaancolak kaancolak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitsudome-r
Copy link
Member

For the distortion correction, we reverted migration to point_cloud_msg_wrapper.
Should we wait for this to be fixed?

@stale
Copy link

stale bot commented Jan 21, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Jan 21, 2023
@esteve
Copy link
Contributor Author

esteve commented Jan 21, 2023

@mitsudome-r my apologies for the slow response, my notifications were not working properly. I agree on waiting for autowarefoundation/autoware-documentation#180 to be fixed

@yukkysaito yukkysaito added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Sep 21, 2023
@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Sep 21, 2023
@miursh
Copy link
Contributor

miursh commented Sep 21, 2023

@mitsudome-r @esteve
Do we still have the motivation to use this point_cloud_msg_wrapper?
If not, would it be acceptable to close this PR for now?

@miursh
Copy link
Contributor

miursh commented Oct 26, 2023

We are closing this issue for now since there has been no response for a month. Please feel free to reopen it if the issue still persists.

@miursh miursh closed this Oct 26, 2023
@esteve
Copy link
Contributor Author

esteve commented Oct 26, 2023

@miursh thanks

@esteve esteve deleted the point-cloud-msg-wrapper-ocupancy-grid-map-outlier-filter branch October 26, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants