Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(obstacle_stop_planner): fix hunting collision point #1627

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Aug 18, 2022

Description

This bug was caused by #1458.
If the index of latest_stop_point_ is used as it is, it causes out of range when the trajectory suddenly changes its shape.
The index needs to be updated with the current trajectory.

[openscenario_interpreter_node-3] [component_container_mt-49] latest_stop_point_.get().index : 708
[openscenario_interpreter_node-3] [component_container_mt-49] output.size() : 695
[openscenario_interpreter_node-3] [component_container_mt-49] terminate called after throwing an instance of 'std::out_of_range'
[openscenario_interpreter_node-3] [component_container_mt-49]   what():  vector::_M_range_check: __n (which is 708) >= this->size() (which is 695)

Related links

#1458

Tests performed

psim

Notes for reviewers

This is TIER IV internal scenario test of pull_over but it reproduces the bug. (not always but sometimes)
https://evaluation.tier4.jp/evaluation/reports/0d07ff47-c173-53bb-8e6d-f5b9f43924fd/tests/8eb804b2-7244-5355-8a8c-89ac7994ff56/355badd4-2f56-57a2-b092-bd61995bfdd0?project_id=prd_jt

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #1627 (f267e69) into main (90e4e78) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1627      +/-   ##
==========================================
- Coverage   10.77%   10.74%   -0.03%     
==========================================
  Files        1111     1111              
  Lines       78542    78732     +190     
  Branches    18555    18555              
==========================================
  Hits         8462     8462              
- Misses      61226    61416     +190     
  Partials     8854     8854              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.75% <0.00%> (ø) Carriedforward from 90e4e78

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
planning/obstacle_stop_planner/src/node.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙏

@kosuke55 kosuke55 merged commit fa25a2f into autowarefoundation:main Aug 19, 2022
@kosuke55 kosuke55 deleted the fix/obstacle_stop_hunting branch August 19, 2022 01:18
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
1222-takeshi referenced this pull request in tier4/autoware.universe Oct 13, 2022
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
1222-takeshi referenced this pull request in tier4/autoware.universe Oct 13, 2022
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
1222-takeshi referenced this pull request in tier4/autoware.universe Oct 13, 2022
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…dation#1627)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
1222-takeshi referenced this pull request in tier4/autoware.universe Oct 18, 2022
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 referenced this pull request in tier4/autoware.universe Nov 10, 2022
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 referenced this pull request in tier4/autoware.universe Nov 30, 2022
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
sfukuta referenced this pull request in tier4/autoware.universe Aug 2, 2023
Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>
sfukuta referenced this pull request in tier4/autoware.universe Dec 19, 2023
* Adapted from PR #1458

Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>

* Adapted from PR #1627

Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>

* fix parameter name

Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>

* Adapted from PR autowarefoundation#2647

Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>

* ci(pre-commit): autofix

* fix build error

* ci(pre-commit): autofix

* remove comment line

* remove logic

* Delete parameters other than those added this time

* ci(pre-commit): autofix

* add stop vehicle check

* ci(pre-commit): autofix

* fix stop velocity threshold

* fix engage obstacle clear and stop threshold

* ci(pre-commit): autofix

---------

Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
asa-naki referenced this pull request in tier4/autoware.universe Sep 17, 2024
* Adapted from PR #1458

Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>

* Adapted from PR #1627

Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>

* fix parameter name

Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>

* Adapted from PR autowarefoundation#2647

Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>

* ci(pre-commit): autofix

* fix build error

* ci(pre-commit): autofix

* remove comment line

* remove logic

* Delete parameters other than those added this time

* ci(pre-commit): autofix

* add stop vehicle check

* ci(pre-commit): autofix

* fix stop velocity threshold

* fix engage obstacle clear and stop threshold

* ci(pre-commit): autofix

---------

Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
asa-naki referenced this pull request in tier4/autoware.universe Sep 18, 2024
* fix(system_monitor): extend command line to display (backport autowarefoundation#4553) (#768)

fix(system_monitor): extend command line to display (autowarefoundation#4553)

Signed-off-by: ito-san <fumihito.ito@tier4.jp>
Co-authored-by: ito-san <57388357+ito-san@users.noreply.github.com>

* feat(behavior_path_planner): resample output path (backport #1604) (#782)

feat(behavior_path_planner): resample output path (#1604)

* feat(behavior_path_planner): resample output path



* update param

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>

* ci: add dispatch-push-event workflow  (#803)

* ci: add dispatch-push-event workflow

Signed-off-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>

* fix: change APP KEY

Signed-off-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>

* chore: use strategy

Signed-off-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>

* chore: change trigger

Signed-off-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>

* pre-commit fixes

Signed-off-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>

* Update .github/workflows/dispatch-push-event.yaml

* Update .github/workflows/dispatch-push-event.yaml

* style(pre-commit): autofix

* Update .github/workflows/dispatch-push-event.yaml

---------

Signed-off-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix(behavior_path): only apply spline interpolation for its output, not for turn_signal processing (#909)

* fix(behavior_path): only apply spline interpolate for output, not for turn_signal processing

* fix implementation

* ci(pre-commit): autofix

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix(behavior_path): fix base points vanishing and inconsistent lane_ids on the spline interpolated path (#929)

* add base points to resampled path in behavior_path

* Revert "fix(behavior_path): only apply spline interpolation for its output, not for turn_signal processing (#909)"

This reverts commit c80c986.

* ci(pre-commit): autofix

* fix insert

* fix: not interpolate behavior velocity path

* Revert "Revert "fix(behavior_path): only apply spline interpolation for its output, not for turn_signal processing (#909)""

This reverts commit e6dd540.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix(system_monitor): fix program command line reading (backport autowarefoundation#5191, autowarefoundation#5430) (#995)

* perf(system_monitor): fix program command line reading (autowarefoundation#5191)

* Fix program command line reading

Signed-off-by: Owen-Liuyuxuan <uken.ryu@tier4.jp>

* style(pre-commit): autofix

* fix spelling commandline->command_line

Signed-off-by: Owen-Liuyuxuan <uken.ryu@tier4.jp>

---------

Signed-off-by: Owen-Liuyuxuan <uken.ryu@tier4.jp>
Co-authored-by: Owen-Liuyuxuan <uken.ryu@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix(system_monitor): output command line (autowarefoundation#5430)

* fix(system_monitor): output command line

Signed-off-by: takeshi.iwanari <takeshi.iwanari@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: takeshi.iwanari <takeshi.iwanari@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

---------

Signed-off-by: Owen-Liuyuxuan <uken.ryu@tier4.jp>
Signed-off-by: takeshi.iwanari <takeshi.iwanari@tier4.jp>
Co-authored-by: Yuxuan Liu <619684051@qq.com>
Co-authored-by: Owen-Liuyuxuan <uken.ryu@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: takeshi-iwanari <takeshi.iwanari@tier4.jp>
Co-authored-by: Akihisa Nagata <54956813+asa-naki@users.noreply.github.com>

* feat(obstacle_stop): upd obstacle hunting (#1068)

* Adapted from PR #1458

Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>

* Adapted from PR #1627

Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>

* fix parameter name

Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>

* Adapted from PR autowarefoundation#2647

Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>

* ci(pre-commit): autofix

* fix build error

* ci(pre-commit): autofix

* remove comment line

* remove logic

* Delete parameters other than those added this time

* ci(pre-commit): autofix

* add stop vehicle check

* ci(pre-commit): autofix

* fix stop velocity threshold

* fix engage obstacle clear and stop threshold

* ci(pre-commit): autofix

---------

Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix(obstacle_avoidance_planner): add empty check (#1285)

* fix(obstacle_avoidance_planner): add empty check

* ci(pre-commit): autofix

* add invalid_argument

* delete empty check

* return code moved to end

* add warning log

* update rclcpp_debug

* delete debug log

* Delete unnecessary blank lines

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix(virtual traffic light): suppress lauch (#1290)

* suppress launch

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

* add existence check

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

---------

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Co-authored-by: Shigekazu Fukuta <107168699+sfukuta@users.noreply.github.com>

* revert: #929,#909,#782

* revert: #1068
- d56c191.

---------

Signed-off-by: ito-san <fumihito.ito@tier4.jp>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
Signed-off-by: Owen-Liuyuxuan <uken.ryu@tier4.jp>
Signed-off-by: takeshi.iwanari <takeshi.iwanari@tier4.jp>
Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: ito-san <57388357+ito-san@users.noreply.github.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Yuxuan Liu <619684051@qq.com>
Co-authored-by: Owen-Liuyuxuan <uken.ryu@tier4.jp>
Co-authored-by: takeshi-iwanari <takeshi.iwanari@tier4.jp>
Co-authored-by: Shigekazu Fukuta <107168699+sfukuta@users.noreply.github.com>
Co-authored-by: Yuki TAKAGI <141538661+yuki-takagi-66@users.noreply.github.com>
kosuke55 pushed a commit that referenced this pull request Nov 27, 2024
#1627)

* solve issue with arc length



* fix problem with points one vehicle apart from path



---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants