Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_ad_api_specs): modify interface version api to use spec package #1677

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Aug 24, 2022

Description

  • Add the interface definition package for AD API.
  • Remove service argument macro.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
…isamu-takagi/autoware.universe into feature/ad-api/modify-interface-version
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@isamu-takagi isamu-takagi self-assigned this Aug 24, 2022
@isamu-takagi isamu-takagi changed the title Feature/ad api/modify interface version feat(autoware_ad_api_specs): modify interface version api to use spec package Aug 24, 2022
@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #1677 (2a0bc7e) into main (df06f93) will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##             main    #1677   +/-   ##
=======================================
  Coverage   10.71%   10.71%           
=======================================
  Files        1103     1103           
  Lines       78404    78409    +5     
  Branches    18648    18650    +2     
=======================================
+ Hits         8400     8404    +4     
  Misses      61089    61089           
- Partials     8915     8916    +1     
Flag Coverage Δ *Carryforward flag
differential 71.42% <50.00%> (?)
total 10.69% <100.00%> (ø) Carriedforward from df06f93

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
system/default_ad_api/src/interface.cpp 75.00% <75.00%> (+3.57%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@isamu-takagi isamu-takagi merged commit d434e87 into autowarefoundation:main Aug 24, 2022
@isamu-takagi isamu-takagi deleted the feature/ad-api/modify-interface-version branch August 24, 2022 10:30
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
… package (tier4#1677)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
… package (tier4#1677)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
… package (tier4#1677)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
… package (autowarefoundation#1677)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
… package (tier4#1677)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants