-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(run_out): refactor debug markers #1811
refactor(run_out): refactor debug markers #1811
Conversation
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Codecov Report
@@ Coverage Diff @@
## main #1811 +/- ##
==========================================
- Coverage 10.74% 10.70% -0.04%
==========================================
Files 1148 1148
Lines 84761 85032 +271
Branches 20451 20620 +169
==========================================
Hits 9106 9106
- Misses 66301 66559 +258
- Partials 9354 9367 +13
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* refactor(run_out): change topic for debug marker Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: modify debug points Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: modify debug polygons Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: remove unused variables Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: remove unnecessary marker Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: set height of debug polygons Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: modify the size of debug points Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: change the name of debug texts Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: fix the height of debug points Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: remove unused function Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
* refactor(run_out): change topic for debug marker Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: modify debug points Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: modify debug polygons Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: remove unused variables Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: remove unnecessary marker Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: set height of debug polygons Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: modify the size of debug points Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: change the name of debug texts Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: fix the height of debug points Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: remove unused function Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
* refactor(run_out): change topic for debug marker Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: modify debug points Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: modify debug polygons Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: remove unused variables Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: remove unnecessary marker Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: set height of debug polygons Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: modify the size of debug points Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: change the name of debug texts Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: fix the height of debug points Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: remove unused function Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
* refactor(run_out): change topic for debug marker Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: modify debug points Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: modify debug polygons Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: remove unused variables Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: remove unnecessary marker Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: set height of debug polygons Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: modify the size of debug points Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: change the name of debug texts Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: fix the height of debug points Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: remove unused function Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Description
Refactor for debug marker of run out module.
There are no effects to the actual behavior.
simplescreenrecorder-2022-09-08_18.35.41.mp4
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.