-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ndt_omp): migrate a package into universe #2176
feat(ndt_omp): migrate a package into universe #2176
Conversation
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Codecov ReportBase: 10.81% // Head: 10.85% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2176 +/- ##
==========================================
+ Coverage 10.81% 10.85% +0.04%
==========================================
Files 1178 1177 -1
Lines 84623 84265 -358
Branches 19945 19945
==========================================
Hits 9148 9148
+ Misses 65763 65405 -358
Partials 9712 9712
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the nice PR!
Basically, PR seems to be good 👍
However, I am not familiar with the licensing, so please wait for reviews or comments from other people who are familiar with it.
Signed-off-by: kminoda <koji.minoda@tier4.jp>
…m:kminoda/autoware.universe into feat/move_ndt_omp_from_vendor_to_universe
I asked AWF community for the opinions on this PR. I will wait for about a week and move on with this PR afterwards. |
Signed-off-by: kminoda koji.minoda@tier4.jp
Description
Migrating
ndt_omp
package from https://github.com/tier4/ndt_omp into universe.Since we are planning to make a radical change to this package (as well as
ndt_scan_matcher
), the package is no longer necessary to be a forked repository. So I would like to migrate the package in universe so that the modification on this package would be easier to handle.Note:
autoware_cmake
).Related links
Should be merged at the same time with...
Tests performed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.