Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ndt_omp): migrate a package into universe #2176

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Oct 28, 2022

Signed-off-by: kminoda koji.minoda@tier4.jp

Description

Migrating ndt_omp package from https://github.com/tier4/ndt_omp into universe.

Since we are planning to make a radical change to this package (as well as ndt_scan_matcher), the package is no longer necessary to be a forked repository. So I would like to migrate the package in universe so that the modification on this package would be easier to handle.

Note:

  • I would like to make the modification from the original package as little as possible for easier reviewing, so the package is NOT modified except
    • an additional license description in Readme
    • removing apps
    • applying pre-commit
  • As a next step, I am planning to modify the CMakeLists.txt and packages.xml so that they will align with the other Autoware packages (e.g. including autoware_cmake).

Related links

Should be merged at the same time with...

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

kminoda and others added 3 commits October 28, 2022 17:19
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Base: 10.81% // Head: 10.85% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (f71d970) compared to base (4d92d1c).
Patch has no changes to coverable lines.

❗ Current head f71d970 differs from pull request most recent head c1776c4. Consider uploading reports for the commit c1776c4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2176      +/-   ##
==========================================
+ Coverage   10.81%   10.85%   +0.04%     
==========================================
  Files        1178     1177       -1     
  Lines       84623    84265     -358     
  Branches    19945    19945              
==========================================
  Hits         9148     9148              
+ Misses      65763    65405     -358     
  Partials     9712     9712              
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 10.83% <ø> (+0.04%) ⬆️ Carriedforward from a23122e

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
perception/tensorrt_yolo/src/nodelet.cpp 0.00% <0.00%> (ø)
perception/lidar_centerpoint/src/node.cpp 0.00% <0.00%> (ø)
perception/tensorrt_yolo/lib/src/trt_yolo.cpp 0.00% <0.00%> (ø)
...erception/tensorrt_yolo/lib/include/calibrator.hpp 0.00% <0.00%> (ø)
...erception/tensorrt_yolo/lib/include/cuda_utils.hpp 0.00% <0.00%> (ø)
...tion/traffic_light_classifier/utils/trt_common.cpp 0.00% <0.00%> (ø)
...on/lidar_apollo_instance_segmentation/src/node.cpp 0.00% <0.00%> (ø)
...on/traffic_light_classifier/src/cnn_classifier.cpp 0.00% <0.00%> (ø)
...on/traffic_light_ssd_fine_detector/src/nodelet.cpp 0.00% <0.00%> (ø)
...lidar_centerpoint/lib/network/tensorrt_wrapper.cpp 0.00% <0.00%> (ø)
... and 39 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

kminoda and others added 11 commits October 31, 2022 10:12
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda self-assigned this Nov 1, 2022
@kminoda kminoda added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Nov 1, 2022
@kminoda kminoda marked this pull request as ready for review November 1, 2022 12:45
Copy link
Contributor

@KYabuuchi KYabuuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice PR!
Basically, PR seems to be good 👍

However, I am not familiar with the licensing, so please wait for reviews or comments from other people who are familiar with it.

kminoda and others added 3 commits November 2, 2022 10:35
Signed-off-by: kminoda <koji.minoda@tier4.jp>
…m:kminoda/autoware.universe into feat/move_ndt_omp_from_vendor_to_universe
@kminoda
Copy link
Contributor Author

kminoda commented Nov 2, 2022

I asked AWF community for the opinions on this PR. I will wait for about a week and move on with this PR afterwards.
https://github.com/orgs/autowarefoundation/discussions/2995

@kminoda kminoda closed this Nov 2, 2022
@kminoda kminoda deleted the feat/move_ndt_omp_from_vendor_to_universe branch November 30, 2022 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants