Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stop_line): z position of stop point #2239

Merged
merged 1 commit into from
Nov 8, 2022
Merged

fix(stop_line): z position of stop point #2239

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion planning/behavior_velocity_planner/src/scene_module/stop_line/scene.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ bool StopLineModule::modifyPathVelocity(

const auto stop_point_idx = stop_point->first;
auto stop_pose = stop_point->second;
stop_pose.position.z = (stop_line_[0].z() + stop_line_[1].z()) / 2.0;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When committing this line, I just followed the original implementation before my PR.
Currently, z position is interpolated from the path. So it makes sense to remove this line.

/**
* @brief : calculate signed arc length consider stop margin from stop line
Expand Down