refactor(ekf_localizer): remove the prediction function to improve referential transparency #2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IshitaTakeshi
requested review from
kminoda,
TakaHoribe and
YamatoAndo
as code owners
Codecov ReportBase: 11.10% // Head: 11.10% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2269 +/- ##
========================================
Coverage 11.10% 11.10%
========================================
Files 1208 1208
Lines 86573 86737 +164
Branches 20829 20967 +138
========================================
+ Hits 9612 9633 +21
- Misses 66805 66940 +135
- Partials 10156 10164 +8
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
IshitaTakeshi
added
the
component:localization
kminoda
reviewed
Nov 11, 2022
kminoda
approved these changes
Nov 30, 2022
HansRobo
pushed a commit
to HansRobo/autoware.universe
that referenced
this pull request
Dec 16, 2022
…ferential transparency (autowarefoundation#2269) * Remove 'predictKinematicsModel' * Move the model description to state_transition.cpp Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kminoda
pushed a commit
to kminoda/autoware.universe
that referenced
this pull request
Jan 6, 2023
…ferential transparency (autowarefoundation#2269) * Remove 'predictKinematicsModel' * Move the model description to state_transition.cpp Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the 'predictKinematicsModel' function to improve referential transparency
Related links
Tests performed
No tests preformed yet, but this modification improves testability in the future.
I checked the behavior in the logging simulator.
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.