feat(radar_static_pointcloud_filter): add radar_static_pointcloud_filter package #2362

scepter914 · 2022-11-24T05:47:36Z

Description

Add radar_static_pointcloud_filter package.
This package follow proposed radar sensing architecture.

Tests performed

Test by rosbag.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.
The PR has been properly tested.
The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.
The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…ter package Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>

sensing/radar_static_pointcloud_filter/CMakeLists.txt

Signed-off-by: scepter914 <scepter914@gmail.com>

...cloud_filter/src/radar_static_pointcloud_filter_node/radar_static_pointcloud_filter_node.cpp

Signed-off-by: scepter914 <scepter914@gmail.com>

codecov · 2022-11-24T06:48:16Z

Codecov Report

Base: 10.47% // Head: 10.51% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (4cdef57) compared to base (1940b87).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2362      +/-   ##
==========================================
+ Coverage   10.47%   10.51%   +0.03%     
==========================================
  Files        1248     1248              
  Lines       91327    90991     -336     
  Branches    21037    21033       -4     
==========================================
  Hits         9566     9566              
+ Misses      71573    71239     -334     
+ Partials    10188    10186       -2

Flag	Coverage Δ		*Carryforward flag
differential	`0.00% <0.00%> (?)`
total	`10.49% <0.00%> (+0.04%)`	⬆️	Carriedforward from 192d606

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
.../lane_departure_checker/lane_departure_checker.hpp	`0.00% <ø> (ø)`
...rture_checker_node/lane_departure_checker_node.cpp	`0.41% <0.00%> (ø)`
...ion/crosswalk_traffic_light_estimator/src/node.cpp	`0.00% <0.00%> (ø)`
.../include/traffic_light_map_based_detector/node.hpp	`0.00% <ø> (ø)`
...tion/traffic_light_map_based_detector/src/node.cpp	`0.00% <0.00%> (ø)`
...havior_path_planner/behavior_path_planner_node.hpp	`0.00% <ø> (ø)`
...or_path_planner/src/behavior_path_planner_node.cpp	`0.19% <0.00%> (+<0.01%)`	⬆️
...clude/freespace_planner/freespace_planner_node.hpp	`0.00% <ø> (ø)`
...r/src/freespace_planner/freespace_planner_node.cpp	`0.00% <0.00%> (ø)`
.../src/goal_pose_visualizer/goal_pose_visualizer.cpp	`0.00% <0.00%> (ø)`
... and 80 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: scepter914 <scepter914@gmail.com>

…m/scepter914/autoware.universe into feat/radar_static_pointcloud_filter

Signed-off-by: scepter914 <scepter914@gmail.com>

...cloud_filter/src/radar_static_pointcloud_filter_node/radar_static_pointcloud_filter_node.cpp

…loud_filter_node/radar_static_pointcloud_filter_node.cpp Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>

yukkysaito

LGTM

…ter package (autowarefoundation#2362) * feat(radar_static_pointcloud_filter): add radar_static_pointcloud_filter package Signed-off-by: scepter914 <scepter914@gmail.com> * apply pre-commit Signed-off-by: scepter914 <scepter914@gmail.com> * refactor Signed-off-by: scepter914 <scepter914@gmail.com> * use autoware_cmame in CMakeLists.txt Signed-off-by: scepter914 <scepter914@gmail.com> * delete transform member variable Signed-off-by: scepter914 <scepter914@gmail.com> * add dependancy Signed-off-by: scepter914 <scepter914@gmail.com> * fix transform Signed-off-by: scepter914 <scepter914@gmail.com> * add code maintainer Signed-off-by: scepter914 <scepter914@gmail.com> * ci(pre-commit): autofix * fix duration time Signed-off-by: scepter914 <scepter914@gmail.com> * change duration time Signed-off-by: scepter914 <scepter914@gmail.com> * Update sensing/radar_static_pointcloud_filter/src/radar_static_pointcloud_filter_node/radar_static_pointcloud_filter_node.cpp Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Signed-off-by: scepter914 <scepter914@gmail.com> * fix from variable renaming Signed-off-by: scepter914 <scepter914@gmail.com> * fix function of convert velocity from doppler velocity Signed-off-by: scepter914 <scepter914@gmail.com> Signed-off-by: scepter914 <scepter914@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>

…ter package (autowarefoundation#2362) * feat(radar_static_pointcloud_filter): add radar_static_pointcloud_filter package Signed-off-by: scepter914 <scepter914@gmail.com> * apply pre-commit Signed-off-by: scepter914 <scepter914@gmail.com> * refactor Signed-off-by: scepter914 <scepter914@gmail.com> * use autoware_cmame in CMakeLists.txt Signed-off-by: scepter914 <scepter914@gmail.com> * delete transform member variable Signed-off-by: scepter914 <scepter914@gmail.com> * add dependancy Signed-off-by: scepter914 <scepter914@gmail.com> * fix transform Signed-off-by: scepter914 <scepter914@gmail.com> * add code maintainer Signed-off-by: scepter914 <scepter914@gmail.com> * ci(pre-commit): autofix * fix duration time Signed-off-by: scepter914 <scepter914@gmail.com> * change duration time Signed-off-by: scepter914 <scepter914@gmail.com> * Update sensing/radar_static_pointcloud_filter/src/radar_static_pointcloud_filter_node/radar_static_pointcloud_filter_node.cpp Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Signed-off-by: scepter914 <scepter914@gmail.com> * fix from variable renaming Signed-off-by: scepter914 <scepter914@gmail.com> * fix function of convert velocity from doppler velocity Signed-off-by: scepter914 <scepter914@gmail.com> Signed-off-by: scepter914 <scepter914@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Signed-off-by: kminoda <koji.minoda@tier4.jp>

scepter914 added 2 commits November 24, 2022 14:24

feat(radar_static_pointcloud_filter): add radar_static_pointcloud_fil…

c497749

…ter package Signed-off-by: scepter914 <scepter914@gmail.com>

apply pre-commit

6405a02

Signed-off-by: scepter914 <scepter914@gmail.com>

scepter914 requested review from aohsato, yukkysaito, drwnz and miursh November 24, 2022 05:47

github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) labels Nov 24, 2022

refactor

2e8f0ba

Signed-off-by: scepter914 <scepter914@gmail.com>

yukkysaito reviewed Nov 24, 2022

View reviewed changes

sensing/radar_static_pointcloud_filter/CMakeLists.txt Outdated Show resolved Hide resolved

yukkysaito mentioned this pull request Nov 24, 2022

feat(radar_scan_to_pointcloud2): add radar_scan_to_pointcloud2 package #2336

Merged

7 tasks

use autoware_cmame in CMakeLists.txt

2aa1387

Signed-off-by: scepter914 <scepter914@gmail.com>

yukkysaito reviewed Nov 24, 2022

View reviewed changes

...cloud_filter/src/radar_static_pointcloud_filter_node/radar_static_pointcloud_filter_node.cpp Outdated Show resolved Hide resolved

scepter914 added 2 commits November 24, 2022 15:24

delete transform member variable

e1f2437

Signed-off-by: scepter914 <scepter914@gmail.com>

add dependancy

a0f29e1

Signed-off-by: scepter914 <scepter914@gmail.com>

scepter914 changed the title ~~feat(radar_static_pointcloud_filter): add radar_static_pointcloud_filter package~~ feat(radar_static_pointcloud_filter): add radar_static_pointcloud_filter package Nov 24, 2022

fix transform

bb7104f

Signed-off-by: scepter914 <scepter914@gmail.com>

scepter914 force-pushed the feat/radar_static_pointcloud_filter branch from 65e89e4 to bb7104f Compare November 24, 2022 07:07

scepter914 and others added 7 commits November 24, 2022 18:27

Merge branch 'main' into feat/radar_static_pointcloud_filter

88e64af

Merge branch 'main' into feat/radar_static_pointcloud_filter

d2abfaf

Merge branch 'main' into feat/radar_static_pointcloud_filter

71d59b6

add code maintainer

fa833d9

Signed-off-by: scepter914 <scepter914@gmail.com>

ci(pre-commit): autofix

4ac5be2

fix duration time

53437ff

Signed-off-by: scepter914 <scepter914@gmail.com>

Merge branch 'feat/radar_static_pointcloud_filter' of ssh://github.co…

40d3d9a

…m/scepter914/autoware.universe into feat/radar_static_pointcloud_filter

scepter914 and others added 2 commits November 25, 2022 18:10

change duration time

6fd0875

Signed-off-by: scepter914 <scepter914@gmail.com>

Merge branch 'main' into feat/radar_static_pointcloud_filter

dd5fb71

yukkysaito reviewed Nov 26, 2022

View reviewed changes

...cloud_filter/src/radar_static_pointcloud_filter_node/radar_static_pointcloud_filter_node.cpp Outdated Show resolved Hide resolved

yukkysaito reviewed Nov 26, 2022

View reviewed changes

...cloud_filter/src/radar_static_pointcloud_filter_node/radar_static_pointcloud_filter_node.cpp Outdated Show resolved Hide resolved

scepter914 and others added 3 commits November 29, 2022 13:31

Update sensing/radar_static_pointcloud_filter/src/radar_static_pointc…

77f602b

…loud_filter_node/radar_static_pointcloud_filter_node.cpp Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Signed-off-by: scepter914 <scepter914@gmail.com>

fix from variable renaming

86fd199

Signed-off-by: scepter914 <scepter914@gmail.com>

fix function of convert velocity from doppler velocity

42b3c34

Signed-off-by: scepter914 <scepter914@gmail.com>

scepter914 force-pushed the feat/radar_static_pointcloud_filter branch from 331cf53 to 42b3c34 Compare November 29, 2022 04:31

scepter914 added 2 commits November 29, 2022 13:39

Merge branch 'main' into feat/radar_static_pointcloud_filter

093f99b

Merge branch 'main' into feat/radar_static_pointcloud_filter

192d606

yukkysaito self-requested a review November 30, 2022 02:28

yukkysaito approved these changes Nov 30, 2022

View reviewed changes

Merge branch 'main' into feat/radar_static_pointcloud_filter

4cdef57

scepter914 merged commit 19a0039 into autowarefoundation:main Dec 1, 2022

scepter914 deleted the feat/radar_static_pointcloud_filter branch December 1, 2022 01:34

tier4-autoware-public-bot bot mentioned this pull request Dec 1, 2022

chore: sync upstream tier4/autoware.universe#195

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(radar_static_pointcloud_filter): add radar_static_pointcloud_filter package #2362

feat(radar_static_pointcloud_filter): add radar_static_pointcloud_filter package #2362

scepter914 commented Nov 24, 2022 •

edited

Loading

codecov bot commented Nov 24, 2022 •

edited

Loading

yukkysaito left a comment

feat(radar_static_pointcloud_filter): add radar_static_pointcloud_filter package #2362

feat(radar_static_pointcloud_filter): add radar_static_pointcloud_filter package #2362

Conversation

scepter914 commented Nov 24, 2022 • edited Loading

Description

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

codecov bot commented Nov 24, 2022 • edited Loading

Codecov Report

yukkysaito left a comment

Choose a reason for hiding this comment

scepter914 commented Nov 24, 2022 •

edited

Loading

codecov bot commented Nov 24, 2022 •

edited

Loading