Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(default_ad_api): fix adapi web server creates two nodes #2404

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Nov 30, 2022

Signed-off-by: Takagi, Isamu isamu.takagi@tier4.jp

Description

Fix adapi web server creates two nodes.

$ ros2 node list | grep web_server
WARNING: Be aware that are nodes in the graph that share an exact name, this can have unintended side effects.
/web_server
/web_server

$ ros2 node list | grep web_server
/default_ad_api/web_server

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Nov 30, 2022
@isamu-takagi isamu-takagi enabled auto-merge (squash) November 30, 2022 06:56
@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Base: 10.46% // Head: 10.46% // No change to project coverage 👍

Coverage data is based on head (093c69f) compared to base (a790489).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2404   +/-   ##
=======================================
  Coverage   10.46%   10.46%           
=======================================
  Files        1248     1248           
  Lines       91330    91330           
  Branches    21037    21037           
=======================================
  Hits         9561     9561           
  Misses      71580    71580           
  Partials    10189    10189           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 10.44% <ø> (ø) Carriedforward from a790489

*This pull request uses carry forward flags. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@isamu-takagi isamu-takagi merged commit 08f5eaf into autowarefoundation:main Nov 30, 2022
@isamu-takagi isamu-takagi self-assigned this Nov 30, 2022
@isamu-takagi isamu-takagi deleted the fix/adapi-web-server-creates-two-nodes branch November 30, 2022 13:19
TomohitoAndo pushed a commit to tier4/autoware.universe that referenced this pull request Dec 2, 2022
…foundation#2404)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
…foundation#2404)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
…foundation#2404)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants