Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_autoware_utils): add toBoundingBox function #3289

Merged
merged 4 commits into from
Apr 5, 2023

Conversation

purewater0901
Copy link
Contributor

Description

Add a function that convert to bounding box (polygon2d) from base_link pose and some necessary informatino.

Related links

Tests performed

Unit Test

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <purewater0901@gmail.com>
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Apr 5, 2023
@purewater0901 purewater0901 reopened this Apr 5, 2023
Signed-off-by: yutaka <purewater0901@gmail.com>
@purewater0901 purewater0901 enabled auto-merge (squash) April 5, 2023 18:13
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Patch coverage: 42.85% and no project coverage change.

Comparison is base (cc85cf0) 12.42% compared to head (fe4ea02) 12.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3289   +/-   ##
=======================================
  Coverage   12.42%   12.42%           
=======================================
  Files        1365     1365           
  Lines       95252    95295   +43     
  Branches    27171    27197   +26     
=======================================
+ Hits        11835    11844    +9     
- Misses      70900    70921   +21     
- Partials    12517    12530   +13     
Flag Coverage Δ *Carryforward flag
differential 14.91% <42.85%> (?)
total 12.42% <ø> (∅) Carriedforward from fe9c742

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ils/test/src/geometry/test_boost_polygon_utils.cpp 22.56% <28.57%> (+0.56%) ⬆️
...utoware_utils/src/geometry/boost_polygon_utils.cpp 74.50% <71.42%> (-0.23%) ⬇️

... and 1363 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@purewater0901 purewater0901 merged commit d2a348b into main Apr 5, 2023
@purewater0901 purewater0901 deleted the feat/add-to-boudingbox-function branch April 5, 2023 18:53
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants